Verify archive state using a one shot in memory store #12730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Ignored Deployments
|
sadhansood
commented
Jun 27, 2023
| { | ||
| let mut locked = self.0 .0.write().unwrap(); | ||
| locked.checkpoints.clear(); | ||
| locked.sequence_number_to_digest.clear(); |
There was a problem hiding this comment.
delete all previous checkpoints when we add new one
sadhansood
commented
Jun 27, 2023
Comment on lines
+1059
to
+1099
| locked.transactions.clear(); | ||
| locked.effects.clear(); | ||
| locked.contents_digest_to_sequence_number.clear(); | ||
| locked.full_checkpoint_contents.clear(); | ||
| locked.checkpoint_contents.clear(); | ||
| } |
There was a problem hiding this comment.
delete all previous content when we add new one
sadhansood
force-pushed
the
sadhan/verify_checkpoint
branch
2 times, most recently
from
6ab6ebe to
8262c7a
Compare
phoenix-o
approved these changes
Jul 5, 2023
crates/sui-types/src/storage.rs
Outdated
| } | ||
|
|
||
| fn insert_committee(&self, new_committee: Committee) -> Result<(), Self::Error> { | ||
| self.0.insert_committee(new_committee)?; |
There was a problem hiding this comment.
nit: just self.0.insert_committee(new_committee) instead of two lines method should work
crates/sui-types/src/storage.rs
Outdated
| @@ -969,3 +969,138 @@ impl Display for DeleteKind { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Clone, Debug, Default)] | |||
| pub struct OneShotSharedInMemoryStore(SharedInMemoryStore); | |||
There was a problem hiding this comment.
nit: maybe SingleCheckpointInMemoryStore? and a small comment why do we need one
crates/sui-types/src/storage.rs
Outdated
| } | ||
| } | ||
|
|
||
| impl ReadStore for OneShotSharedInMemoryStore { |
There was a problem hiding this comment.
would be nice to avoid all the boilerplate code, but not a blocker.
We could use delegate crate or add a capacity parameter to original InMemoryStore(with default setting of u64::MAX)
sadhansood
force-pushed
the
sadhan/verify_checkpoint
branch
2 times, most recently
from
26a0b42 to
16fe3d9
Compare
sadhansood
force-pushed
the
sadhan/verify_checkpoint
branch
from
16fe3d9 to
03c4291
Compare
longbowlu
pushed a commit
that referenced
this pull request
Jul 6, 2023
## Description Added a shared in memory store which only keeps last checkpoint and its content in memory. This helps iterate over checkpoints really fast as we don't need to use a db and can run verification without writing to rocksdb ever. ## Test Plan Added unit tests
ebmifa
pushed a commit
that referenced
this pull request
Jul 12, 2023
## Description Added a shared in memory store which only keeps last checkpoint and its content in memory. This helps iterate over checkpoints really fast as we don't need to use a db and can run verification without writing to rocksdb ever. ## Test Plan Added unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a shared in memory store which only keeps last checkpoint and its content in memory. This helps iterate over checkpoints really fast as we don't need to use a db and can run verification without writing to rocksdb ever.
Test Plan
Added unit tests