Fix broken image fallback #12679
Merged
Fix broken image fallback #12679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jibz-Mysten
requested review from
Nikhil-Mysten and
hayes-mysten
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
williamrobertson13
approved these changes
Jun 25, 2023
plam-ml
approved these changes
Jun 26, 2023
Jibz-Mysten
force-pushed
the
gj--fix-broken-image-fallback
branch
from
c121581 to
f8f51d7
Compare
Nikhil-Mysten
approved these changes
Jun 26, 2023
ebmifa
pushed a commit
that referenced
this pull request
Jul 12, 2023
## Description Whenever browsing between pages/screens in Explorer and Wallet, the fallback avatar sometime does not show. This addresses it by checking for the URL string before rendering the image Fixes this <img width="1477" alt="Screenshot 2023-06-25 at 6 54 00 PM" src="https://github.com/MystenLabs/sui/assets/126525197/b8706f58-88d0-4277-8464-6983e2b6b193">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whenever browsing between pages/screens in Explorer and Wallet, the fallback avatar sometime does not show. This addresses it by checking for the URL string before rendering the image
Fixes this
