Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting for all dapps and sdk packages #12507

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

hayes-mysten
Copy link
Contributor

@hayes-mysten hayes-mysten commented Jun 15, 2023

Description

This adds eslint and prettier for all files in the sdk and dapps directories.

It also standardizes the prettier configs to apply consistent formatting across all directories.

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@vercel
Copy link

vercel bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 10:53pm
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 10:53pm
offline-signer-helper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 10:53pm
sui-kiosk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 10:53pm
sui-wallet-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 10:53pm
wallet-adapter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 10:53pm

@hayes-mysten hayes-mysten force-pushed the hayes--add-linting-for-all-sdk-packages branch from c149197 to 4d776ff Compare June 15, 2023 01:07
@hayes-mysten hayes-mysten requested a review from a team as a code owner June 15, 2023 01:07
@hayes-mysten hayes-mysten requested review from williamrobertson13 and pchrysochoidis and removed request for a team June 15, 2023 01:07
@vercel vercel bot temporarily deployed to Preview – sui-wallet-kit June 15, 2023 01:08 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer-storybook June 15, 2023 01:08 Inactive
@hayes-mysten hayes-mysten changed the title Add linting for all sdk packages Add linting for all dapps and sdk packages Jun 15, 2023
@vercel vercel bot temporarily deployed to Preview – wallet-adapter June 15, 2023 01:08 Inactive
@hayes-mysten hayes-mysten force-pushed the hayes--add-linting-for-all-sdk-packages branch from 4d776ff to acc2e91 Compare June 15, 2023 01:13
@vercel vercel bot temporarily deployed to Preview – wallet-adapter June 15, 2023 01:14 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer-storybook June 15, 2023 01:14 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-wallet-kit June 15, 2023 01:14 Inactive
@hayes-mysten hayes-mysten force-pushed the hayes--add-linting-for-all-sdk-packages branch from acc2e91 to 95d0ee9 Compare June 15, 2023 01:15
@vercel vercel bot temporarily deployed to Preview – sui-wallet-kit June 15, 2023 01:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-adapter June 15, 2023 01:16 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer-storybook June 15, 2023 01:16 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the Sui repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

@hayes-mysten hayes-mysten force-pushed the hayes--add-linting-for-all-sdk-packages branch from 47839de to d0d5721 Compare June 15, 2023 22:50
@vercel vercel bot temporarily deployed to Preview – sui-wallet-kit June 15, 2023 22:51 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer-storybook June 15, 2023 22:52 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-adapter June 15, 2023 22:52 Inactive
@hayes-mysten hayes-mysten merged commit efc8301 into main Jun 15, 2023
@hayes-mysten hayes-mysten deleted the hayes--add-linting-for-all-sdk-packages branch June 15, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants