Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert committee when handling checkpoint from consensus #12324

Merged
merged 2 commits into from
Jun 3, 2023

Conversation

longbowlu
Copy link
Collaborator

@longbowlu longbowlu commented Jun 2, 2023

Description

In #12212, we refactored handle_checkpoint_from_consensus. The PR missed one thing: when a last checkpoint of an epoch is certified in consensus and sent to state sync, we do not update the committee store. This is problematic because state sync does not reconfig. It means if a validator is slow in reconfiguration (where committee store would also be updated) and gets checkpoints in the next epoch from peers, it will panic in that it couldn't find the committee. This PR fixes it.

Test Plan

for f in `seq 1 20`; do MSIM_TEST_NUM=5 MSIM_TEST_SEED=98$f RUST_LOG=off simt test_simulated_load_reconfig_restarts --no-capture > log-$f 2>&1 &; done
grep FAIL log-*

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Insert committee when handling checkpoint from consensus.

@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
offline-signer-helper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2023 0:14am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Jun 3, 2023 0:14am
explorer-storybook ⬜️ Ignored (Inspect) Jun 3, 2023 0:14am
sui-wallet-kit ⬜️ Ignored (Inspect) Jun 3, 2023 0:14am
wallet-adapter ⬜️ Ignored (Inspect) Jun 3, 2023 0:14am

@longbowlu longbowlu force-pushed the insert-committte-for-checkpoint-from-consensus branch from 5168737 to 80f3ba3 Compare June 3, 2023 00:13
@longbowlu longbowlu enabled auto-merge (squash) June 3, 2023 00:30
@longbowlu longbowlu merged commit 1ddfea7 into main Jun 3, 2023
@longbowlu longbowlu deleted the insert-committte-for-checkpoint-from-consensus branch June 3, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants