Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary workspace versions #12211

Merged
merged 1 commit into from
May 25, 2023
Merged

Remove unnecessary workspace versions #12211

merged 1 commit into from
May 25, 2023

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented May 25, 2023

Description

A few crates don't/shouldn't inherit workspace version. Give them individual versions.
Also the open-json-rpc is generating version using sui-core's version, which is always the workspace version. This is wrong to me. This PR is a short-term fix to just use workspace version directly in open-json-rpc, but we should make it a real version.

Test Plan

cargo build


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
offline-signer-helper ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 9:58pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) May 25, 2023 9:58pm
explorer-storybook ⬜️ Ignored (Inspect) May 25, 2023 9:58pm
sui-wallet-kit ⬜️ Ignored (Inspect) May 25, 2023 9:58pm
wallet-adapter ⬜️ Ignored (Inspect) May 25, 2023 9:58pm

@lxfind lxfind enabled auto-merge (squash) May 25, 2023 21:15
@lxfind lxfind force-pushed the remove-workspace-version branch from f7fc508 to 78eb108 Compare May 25, 2023 21:57
@lxfind lxfind disabled auto-merge May 25, 2023 21:57
@lxfind lxfind requested a review from patrickkuo May 25, 2023 21:57
@lxfind lxfind merged commit 01cbe46 into main May 25, 2023
@lxfind lxfind deleted the remove-workspace-version branch May 25, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants