fix big amount bug and 0 balance validation #12187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jordan-Mysten
approved these changes
May 24, 2023
| @@ -35,7 +35,8 @@ export function useGetAllCoins(coinType: string, address?: SuiAddress | null) { | |||
|
|
|||
| return allData; | |||
| }, | |||
| enabled: !!address, | |||
| enabled: !!address && !!coinType, | |||
| staleTime: 5000, | |||
There was a problem hiding this comment.
Fine with this approach for now, but we probably should rework this flow in general to do JIT coin fetching and just use the balance instead of using the cached fetch.
Jibz-Mysten
force-pushed
the
gj--wallet-send-large-amount-bug-fix
branch
from
c526356 to
8105f12
Compare
Jibz-Mysten
force-pushed
the
gj--wallet-send-large-amount-bug-fix
branch
from
8105f12 to
0a0aee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Fix the validation showing a 0 balance issue. Setting stale time to 5000 fixes it. useQuery queryFn
before
Screen.Recording.2023-05-24.at.3.44.10.PM.mov
after
Screen.Recording.2023-05-24.at.3.45.14.PM.mov
Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes