move metered-channel to mysten-metrics #12156
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| let gauge = if let Some(metrics) = mysten_metrics::get_metrics() { | ||
| metrics.channels.with_label_values(&["streamer"]) | ||
| } else { | ||
| // We call init_metrics very early when starting a node. Therefore when this happens, | ||
| // it's probably in a test. | ||
| mysten_metrics::init_metrics(&Registry::default()); | ||
| mysten_metrics::get_metrics() | ||
| .unwrap() | ||
| .channels | ||
| .with_label_values(&["streamer"]) | ||
| }; | ||
|
|
||
| let (tx, rx) = mysten_metrics::metered_channel::channel(buffer, &gauge); | ||
| let gague_clone = gauge.clone(); |
There was a problem hiding this comment.
this is the meat of this PR
There was a problem hiding this comment.
Is it possible to extract the logic to a fn monitored_channel(buffer_size: usize, name: &'static str) in mysten-metrics? It would be useful elsewhere too.
There was a problem hiding this comment.
yeah I want to clean this up eventually, adding a TODO
crates/mysten-metrics/src/lib.rs
Outdated
| channels: register_int_gauge_vec_with_registry!( | ||
| "monitored_channels", | ||
| "Size of channels per callsite.", | ||
| &["callsite"], |
There was a problem hiding this comment.
Maybe call the label name? Other callsite labels have actual file:line as values.
There was a problem hiding this comment.
I thought about it and thought it would be more consistent if we stick with one label for these monitored metrics
There was a problem hiding this comment.
monitored_scope is using 'name' as label name. We may migrate monitored tasks and futures too.
There was a problem hiding this comment.
you are right, I will use name for this
longbowlu
force-pushed
the
move-metered-channel-to-mysten-metrics
branch
from
a5be4b4 to
c21861d
Compare
Description
This PR moves metered-channel from narwhal to mysten-metrics and uses it on
streamerto monitor the channel size.Test Plan
Tested it locally and see the metrics appeared.
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
Moves metered-channel from narwhal to mysten-metrics and uses it on
streamerto monitor the channel size.