Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove days from countdown timeAgo #12141

Merged
merged 6 commits into from
May 23, 2023

Conversation

Jibz-Mysten
Copy link
Contributor

@Jibz-Mysten Jibz-Mysten commented May 22, 2023

Description

Removing days from the countdown timeAgo helper. The wallet Staking Rewards Redeemable was the only place this is visible, and this should be in hours, not days.

Screenshot 2023-05-22 at 12 19 39 PM

Describe the changes or additions included in this PR.

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 10:02pm
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 10:02pm
offline-signer-helper ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 10:02pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
sui-wallet-kit ⬜️ Ignored (Inspect) May 22, 2023 10:02pm
wallet-adapter ⬜️ Ignored (Inspect) May 22, 2023 10:02pm

Copy link
Contributor

@pchrysochoidis pchrysochoidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we use this in explorer? I think we should keep it and probably extend it to support setting specific time unit

Copy link
Contributor

@pchrysochoidis pchrysochoidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment with maxTimeLabelInHours in case we might have other cases as well but this is ok as well

apps/core/src/hooks/useTimeAgo.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants