Split sui-config crate #11968
Merged
Split sui-config crate #11968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
lxfind
force-pushed
the
add-genesis-builder-crate
branch
from
ea864ed to
e7ea46f
Compare
lxfind
force-pushed
the
add-genesis-builder-crate
branch
from
e7ea46f to
1175dfb
Compare
lxfind
requested review from
tharbert,
joyqvq,
kchalkias and
benr-ml
as code owners
lxfind
force-pushed
the
add-genesis-builder-crate
branch
from
1175dfb to
c610895
Compare
lxfind
force-pushed
the
add-genesis-builder-crate
branch
from
c610895 to
3ae6d06
Compare
lxfind
force-pushed
the
add-genesis-builder-crate
branch
from
3ae6d06 to
c99a9cc
Compare
ronny-mysten
pushed a commit
that referenced
this pull request
May 17, 2023
sui-config crate started as a crate for the NodeConfig. However it has grown too much and no longer at the bottom of the dependency chain. This PR splits some modules out of it: 1. Split out sui-genesis-builder. This contains all the code to build a genesis, which depends on the execution component. After this PR, sui-config no longer depends on the execution component, which means we can now pass NodeConfig around even into the execution component, which we have wanted to do for a while. 2. Split out sui-swarm-config. This contains all the configs and builders to create a NetworkConfig for the swarm. It makes it clear now that this is used for swarm, not for production. 3. Renamed swarm.rs into network_config.rs for clarity. 4. Renamed builder.rs into network_config_builder.rs for clarity. 5. Moved FullnodeConfigBuilder out of node.rs into network_config_builder.rs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sui-config crate started as a crate for the NodeConfig.
However it has grown too much and no longer at the bottom of the dependency chain.
This PR splits some modules out of it: