Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Publish & Custom Genesis REST documentation. #1176

Merged
merged 13 commits into from
Apr 7, 2022
Merged

Add Publish & Custom Genesis REST documentation. #1176

merged 13 commits into from
Apr 7, 2022

Conversation

arun-koshy
Copy link
Contributor

Also includes update to sui-move documentation as that tool enables REST Move publishing

…so update sui-move documentation for REST publishing
@arun-koshy arun-koshy requested review from lxfind and awelc March 31, 2022 22:17
@arun-koshy arun-koshy requested a review from Clay-Mysten as a code owner March 31, 2022 22:17
awelc
awelc previously requested changes Mar 31, 2022
doc/src/build/move.md Outdated Show resolved Hide resolved
doc/src/build/move.md Outdated Show resolved Hide resolved
doc/src/build/move.md Outdated Show resolved Hide resolved
doc/src/build/rest-api.md Outdated Show resolved Hide resolved
doc/src/build/rest-api.md Outdated Show resolved Hide resolved
doc/src/build/rest-api.md Outdated Show resolved Hide resolved
doc/src/build/rest-api.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, Arun! This is helpful information. I agree with Adam we can single source these contents in rest.api.md and wallet.md.

doc/src/build/rest-api.md Outdated Show resolved Hide resolved
doc/src/build/rest-api.md Outdated Show resolved Hide resolved
doc/src/build/rest-api.md Outdated Show resolved Hide resolved
doc/src/build/rest-api.md Outdated Show resolved Hide resolved
doc/src/build/rest-api.md Outdated Show resolved Hide resolved
doc/src/build/rest-api.md Outdated Show resolved Hide resolved
doc/src/build/move.md Outdated Show resolved Hide resolved
doc/src/build/move.md Outdated Show resolved Hide resolved
@arun-koshy
Copy link
Contributor Author

Good time to finally install pre-commit & typos after all those spelling mistakes 😅

Make my direct edits to rest-api.md
Make small edits directly to wallet.md
Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Arun! I have just a few small suggestions as I made all of me edits directly in new commits to this same PR here.

I hope this helps. Thank you for these fantastic additions!

doc/src/build/rest-api.md Outdated Show resolved Hide resolved
doc/src/build/rest-api.md Outdated Show resolved Hide resolved
doc/src/build/rest-api.md Outdated Show resolved Hide resolved
doc/src/build/rest-api.md Outdated Show resolved Hide resolved
@arun-koshy
Copy link
Contributor Author

Waiting to update this documentation till I can get publish working locally after PR#1123

@arun-koshy
Copy link
Contributor Author

Thanks for your patience, just needed to update the sui-move code to match the new rest server changes. Should be ready for final review now.

@arun-koshy arun-koshy requested a review from patrickkuo April 7, 2022 20:17
@arun-koshy arun-koshy dismissed awelc’s stale review April 7, 2022 21:09

Completed requested changes

Copy link
Contributor

@patrickkuo patrickkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating sui move to generate Base64!

@arun-koshy arun-koshy merged commit 60ebdf2 into main Apr 7, 2022
@arun-koshy arun-koshy deleted the arun/docs branch April 7, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants