distinguish consensus/non consensus in certificate execution latency #11749
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
crates/sui-core/src/authority.rs
Outdated
| @@ -189,7 +189,8 @@ pub struct AuthorityMetrics { | |||
| batch_size: Histogram, | |||
|
|
|||
| handle_transaction_latency: Histogram, | |||
| execute_certificate_latency: Histogram, | |||
| execute_certificate_consensus_latency: Histogram, | |||
There was a problem hiding this comment.
Just use a label to differentiate between the two?
There was a problem hiding this comment.
I can do that if you prefer that, just curious any particular reason it is better?
There was a problem hiding this comment.
Just in case we need to add more labels for the metric. Also there is currently handle_transaction_latency so it seems nice to maintain execute_certificate_latency.
There was a problem hiding this comment.
not sure what you mean by handle_transaction_latency but I will update to use labels
There was a problem hiding this comment.
I wanted to use two metrics because today we have handle_certificate_non_consensus_latency
and handle_certificate_consensus_latency which are two metrics. But it's not a big deal and I don't have preferences
longbowlu
force-pushed
the
add-tx-digest-to-process-object-index-warning
branch
from
c68d58e to
f89ecd3
Compare
Description
as title, and add more points in the buckets.
Test Plan
CI
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes