Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DbTool] add a few commands to modify database with minimal safety checks #11612

Merged
merged 6 commits into from
May 12, 2023

Conversation

mwtian
Copy link
Member

@mwtian mwtian commented May 2, 2023

Description

There are needs to repair corrupted databases sometimes. Adding a few commands to remove transaction and its outputs, and remove lock.

Test Plan

Tested on fullnodes.


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@vercel
Copy link

vercel bot commented May 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) May 11, 2023 5:37pm
explorer-storybook ⬜️ Ignored (Inspect) May 11, 2023 5:37pm
sui-wallet-kit ⬜️ Ignored (Inspect) May 11, 2023 5:37pm
wallet-adapter ⬜️ Ignored (Inspect) May 11, 2023 5:37pm

@mwtian mwtian force-pushed the set-exec-watermark branch 3 times, most recently from ee0b60b to ce521b4 Compare May 2, 2023 01:29
@mwtian mwtian requested a review from williampsmith May 2, 2023 17:33
@mwtian mwtian force-pushed the set-exec-watermark branch 6 times, most recently from 4d3805f to c142561 Compare May 10, 2023 21:26
@mwtian mwtian force-pushed the set-exec-watermark branch 6 times, most recently from 29959f8 to 764730a Compare May 10, 2023 23:34
@mwtian mwtian force-pushed the set-exec-watermark branch from 764730a to d1ce05a Compare May 10, 2023 23:53
@mwtian mwtian changed the title Force rewind highest checkpoint execution watermark [DbTool] add a few commands to modify database as safe as possible May 11, 2023
@mwtian mwtian changed the title [DbTool] add a few commands to modify database as safe as possible [WIP][DbTool] add a few commands to modify database as safe as possible May 11, 2023
@mwtian mwtian marked this pull request as ready for review May 11, 2023 00:15
@mwtian mwtian requested a review from joyqvq as a code owner May 11, 2023 00:15
crates/sui-core/src/authority/authority_store_tables.rs Outdated Show resolved Hide resolved
crates/sui-core/src/checkpoints/mod.rs Outdated Show resolved Hide resolved
crates/sui-tool/src/db_tool/mod.rs Show resolved Hide resolved
crates/sui-tool/src/db_tool/mod.rs Show resolved Hide resolved
crates/sui-tool/src/db_tool/mod.rs Outdated Show resolved Hide resolved
@mwtian mwtian requested a review from mystenmark May 11, 2023 02:54
@mwtian mwtian requested a review from williampsmith May 11, 2023 17:37
@mwtian mwtian changed the title [WIP][DbTool] add a few commands to modify database as safe as possible [DbTool] add a few commands to modify database with minimal safety checks May 12, 2023
@mwtian mwtian merged commit bdb8081 into main May 12, 2023
@mwtian mwtian deleted the set-exec-watermark branch May 12, 2023 21:44
ronny-mysten pushed a commit that referenced this pull request May 17, 2023
…ecks (#11612)

There are needs to repair corrupted databases sometimes. Adding a few
commands to remove transaction and its outputs, and remove lock.

Tested on fullnodes.

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants