[package upgrades] change upgrade criteria for struct type params #11369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
amnn
approved these changes
Apr 26, 2023
|
|
||
| //# upgrade --package A0 --upgrade-capability 1,1 --sender A | ||
| module A1::base { | ||
| struct Foo<T: store> { } |
There was a problem hiding this comment.
You are also adding a store here, is that intentionaly? That would be incompatible anyway but for another reason.
There was a problem hiding this comment.
Yep! But I just wanted to make sure we were covering that as well here.
tzakian
force-pushed
the
tzakian/disallow-generic-type-changes-on-structs
branch
from
7a7829d to
f23213c
Compare
…e abiliities during upgrades
tzakian
force-pushed
the
tzakian/disallow-generic-type-changes-on-structs
branch
from
f23213c to
2d688f5
Compare
tzakian
added a commit
that referenced
this pull request
Apr 26, 2023
Merged
tzakian
added a commit
that referenced
this pull request
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.