Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mbf-wasm] Adds wasm flag to mbf #11257

Merged
merged 51 commits into from
Sep 7, 2023
Merged

[mbf-wasm] Adds wasm flag to mbf #11257

merged 51 commits into from
Sep 7, 2023

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Apr 24, 2023 •
edited
Loading

Description

Adds WASM support for move-binary-format crate and adds a @mysten/move-binary-format package.

  • adds a move-binary-format package to sdk/
  • adds tests and pnpm setup
  • adds a readme
  • builds for node and for web

Test Plan

  • Tested

Type of Change (Check all that apply)

  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@damirka damirka requested a review from randall-Mysten as a code owner April 24, 2023 15:16
@damirka damirka self-assigned this Apr 24, 2023
@damirka damirka requested a review from ronny-mysten as a code owner April 24, 2023 15:16
@vercel
Copy link

vercel bot commented Apr 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 1:17pm
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 1:17pm
multisig-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 1:17pm
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 1:17pm
sui-kiosk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 1:17pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 1:17pm
sui-wallet-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 1:17pm
wallet-adapter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 1:17pm

@vercel vercel bot temporarily deployed to Preview – sui-wallet-kit April 26, 2023 16:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-adapter April 26, 2023 16:28 Inactive
@vercel vercel bot temporarily deployed to Preview – sui-wallet-kit April 26, 2023 16:28 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer-storybook April 26, 2023 16:29 Inactive
@damirka damirka force-pushed the ds/move-binary-wasm branch from 6c0c4cc to 46c072f Compare April 26, 2023 16:38
@vercel vercel bot temporarily deployed to Preview – sui-wallet-kit April 26, 2023 16:39 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-adapter April 26, 2023 16:39 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer-storybook April 26, 2023 16:40 Inactive
Jordan-Mysten
Jordan-Mysten approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@Jordan-Mysten Jordan-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but LGTM

@vercel vercel bot temporarily deployed to Preview – sui-wallet-kit April 26, 2023 20:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-adapter April 26, 2023 20:32 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer-storybook April 26, 2023 20:33 Inactive
dariorussi
dariorussi approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@dariorussi dariorussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@damirka damirka force-pushed the ds/move-binary-wasm branch from 4dd9970 to c770868 Compare August 7, 2023 20:16
@damirka damirka requested a review from a team as a code owner August 7, 2023 20:16
@vercel vercel bot temporarily deployed to Preview – mysten-ui August 22, 2023 09:35 Inactive
@vercel vercel bot temporarily deployed to Preview – mysten-ui September 5, 2023 18:12 Inactive
@vercel vercel bot temporarily deployed to Preview – mysten-ui September 7, 2023 13:13 Inactive
@vercel vercel bot temporarily deployed to Preview – mysten-ui September 7, 2023 13:17 Inactive
@damirka damirka merged commit ab571e5 into main Sep 7, 2023
@damirka damirka deleted the ds/move-binary-wasm branch September 7, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariorussi dariorussi dariorussi approved these changes

@Jordan-Mysten Jordan-Mysten Jordan-Mysten approved these changes

@tnowacki tnowacki Awaiting requested review from tnowacki

@oxade oxade Awaiting requested review from oxade

@amnn amnn Awaiting requested review from amnn

Assignees

@damirka damirka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.