indexer stability: revert diesel-async changes #11017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
gegaowp
changed the title
wlmyng
approved these changes
Apr 18, 2023
|
it needs a bit more work to revert this back to blocking, working on it now |
gegaowp
force-pushed
the
read-only-blocking
branch
2 times, most recently
from
6a64c75 to
2571bae
Compare
gegaowp
changed the title
gegaowp
force-pushed
the
read-only-blocking
branch
from
9b7f7fc to
94a21cc
Compare
gegaowp
force-pushed
the
read-only-blocking
branch
from
94a21cc to
dd99c0e
Compare
gegaowp
changed the title
gegaowp
added a commit
to gegaowp/sui
that referenced
this pull request
Apr 18, 2023
## Description The reason is that read_only queries will still build tx, see code [pointer](https://github.com/MystenLabs/sui/blob/main/crates/sui-indexer/src/store/mod.rs#L24-L34) and when Diesel gets concurrent tx, it will check if some other tx is in process [here](https://github.com/diesel-rs/diesel/blob/4b2ebca2ddb25f08bf9107869f064f5774efbb83/diesel/src/connection/transaction_manager.rs#L286), if there is another on-going tx, even it is a read-only tx, Diesel will return error AlreadyInTransaction More context can be found in #sui_testnet_n_inc_307 ## Test Plan CI
gegaowp
added a commit
that referenced
this pull request
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reason is that read_only queries will still build tx, see code pointer and when Diesel gets concurrent tx, it will check if some other tx is in process here, if there is another on-going tx, even it is a read-only tx, Diesel will return error AlreadyInTransaction
More context can be found in #sui_testnet_n_inc_307
Test Plan
CI