[bugfix] - make resolve input type for programmable transaction more defensive to avoid array out of bound panic #10344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
bmwill
reviewed
Apr 3, 2023
Comment on lines
1094
to
1098
| match arg { | ||
| &Argument::Input(i) if (i as usize) < inputs.len() => { | ||
| result_types[i as usize] = type_; | ||
| } | ||
| _ => {} |
There was a problem hiding this comment.
You could just use the get api here instead which would return a None if its out of bounds. probably saffer to do it that way too in case this code changes in the future
patrickkuo
force-pushed
the
pat/sui_pt_more_defensive
branch
2 times, most recently
from
ed08dca to
9892968
Compare
bmwill
approved these changes
Apr 4, 2023
patrickkuo
force-pushed
the
pat/sui_pt_more_defensive
branch
from
9892968 to
71b4145
Compare
…o avoid array out of bound panic
patrickkuo
force-pushed
the
pat/sui_pt_more_defensive
branch
from
9a99f1c to
069be11
Compare
wlmyng
pushed a commit
that referenced
this pull request
Apr 6, 2023
…defensive to avoid array out of bound panic (#10344) the code could panic when resolving input types for a malformed programmable transaction, add checks to ensure input arg index is within the input size.
wlmyng
pushed a commit
that referenced
this pull request
Apr 6, 2023
…defensive to avoid array out of bound panic (#10344) ## Description the code could panic when resolving input types for a malformed programmable transaction, add checks to ensure input arg index is within the input size.
Jibz-Mysten
pushed a commit
that referenced
this pull request
Apr 6, 2023
…defensive to avoid array out of bound panic (#10344) ## Description the code could panic when resolving input types for a malformed programmable transaction, add checks to ensure input arg index is within the input size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the code could panic when resolving input types for a malformed programmable transaction, add checks to ensure input arg index is within the input size.