Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] Fix GasBudgetTooHigh and GasBudgetTooLow error #10159

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

666lcz
Copy link
Contributor

@666lcz 666lcz commented Mar 30, 2023

Description

Community is reporting seeing confusing error message like

message": "Error checking transaction input objects: GasBudgetTooLow { gas_budget: 30000, min_budget: 110 }"

where their provided gas_budget is greater than the min_budget. This is because min_budget does not take rgp into consideration

Test Plan

CI build


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@vercel
Copy link

vercel bot commented Mar 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated
explorer ⬜️ Ignored (Inspect) Mar 30, 2023 at 9:12PM (UTC)
explorer-storybook ⬜️ Ignored (Inspect) Mar 30, 2023 at 9:12PM (UTC)
sui-wallet-kit ⬜️ Ignored (Inspect) Mar 30, 2023 at 9:12PM (UTC)
wallet-adapter ⬜️ Ignored (Inspect) Mar 30, 2023 at 9:12PM (UTC)

@666lcz 666lcz requested a review from bmwill March 30, 2023 20:57
@666lcz 666lcz changed the title Fix GasBudgetTooHigh and GasBudgetTooLow error [easy] Fix GasBudgetTooHigh and GasBudgetTooLow error Mar 30, 2023
@666lcz 666lcz requested a review from tzakian March 30, 2023 20:59
@666lcz 666lcz merged commit cf6bc1f into main Mar 30, 2023
@666lcz 666lcz deleted the chris-fix-gas branch March 30, 2023 23:05
666lcz added a commit that referenced this pull request Mar 31, 2023
## Description 

Community is reporting seeing confusing error message like

```
message": "Error checking transaction input objects: GasBudgetTooLow { gas_budget: 30000, min_budget: 110 }"
```

where their provided gas_budget is greater than the min_budget. This is
because `min_budget` does not take rgp into consideration

## Test Plan 

CI build

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
666lcz added a commit that referenced this pull request Mar 31, 2023
…ror (#10159) (#10188)

## Description 

Community is reporting seeing confusing error message like

```
message": "Error checking transaction input objects: GasBudgetTooLow { gas_budget: 30000, min_budget: 110 }"
```

where their provided gas_budget is greater than the min_budget. This is
because `min_budget` does not take rgp into consideration

## Test Plan 

CI build

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes

## Description 

Describe the changes or additions included in this PR.

## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants