[sui-proxy/ cleanup handler/middleware] #10100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
Summary: * cleanup the consumer.rs code * add a new middleware to decode the protobufs Test Plan: tested locally
suiwombat
force-pushed
the
cleanup_proxy
branch
from
2024cfb to
71d71ac
Compare
| fn encode_compress(request: &WriteRequest) -> Result<Vec<u8>, (StatusCode, &'static str)> { | ||
| let mut buf = Vec::new(); | ||
| buf.reserve(request.encoded_len()); | ||
| let Ok(()) = request.encode(&mut buf) else { |
There was a problem hiding this comment.
nit
Suggested change
| let Ok(()) = request.encode(&mut buf) else { | |
| if request.encode(&mut buf).is_err() { |
There was a problem hiding this comment.
i'll fix this on the next pr. thanks <3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan:
tested locally
Description
Describe the changes or additions included in this PR.
Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes