Skip to content

Commit

Permalink
[sui-proxy/ remove remote_host label] (#11603)
Browse files Browse the repository at this point in the history 
Summary:

* this causes undesirable behavior with some of our queries when we add
multiple proxy backends.
* we don't need this data so, lets remove it. It should fall out of
scope from the tsdb in time, without issue.

Test Plan:

cargo build

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
  • Loading branch information
@suiwombat
suiwombat authored May 2, 2023
1 parent d721ceb commit 78d7385
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions crates/sui-proxy/src/consumer.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,10 @@ impl ProtobufDecoder {

// populate labels in place for our given metric family data
pub fn populate_labels(
name: String, // host field for grafana agent (from chain data)
network: String, // network name from ansible (via config)
inventory_hostname: String, // inventory_name from ansible (via config)
name: String, // host field for grafana agent (from chain data)
network: String, // network name from ansible (via config)
// TODO use in stderr logging, see below
_inventory_hostname: String, // inventory_name from ansible (via config)
data: Vec<proto::MetricFamily>,
) -> Vec<proto::MetricFamily> {
let timer = CONSUMER_OPERATION_DURATION
Expand All @@ -119,11 +120,12 @@ pub fn populate_labels(
host_label.set_name("host".into());
host_label.set_value(name);

let mut relay_host_label = proto::LabelPair::default();
relay_host_label.set_name("relay_host".into());
relay_host_label.set_value(inventory_hostname);
// TODO add this back in via stderr logging only and not in relayed samples
// let mut relay_host_label = proto::LabelPair::default();
// relay_host_label.set_name("relay_host".into());
// relay_host_label.set_value(inventory_hostname);

let labels = vec![network_label, host_label, relay_host_label];
let labels = vec![network_label, host_label];

let mut data = data;
// add our extra labels to our incoming metric data
Expand Down Expand Up @@ -330,7 +332,6 @@ mod tests {
&create_labels(vec![
("network", "unittest-network"),
("host", "validator-0"),
("relay_host", "inventory-hostname"),
])
);
}
Expand Down

1 comment on commit 78d7385

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 Validators 500/s Owned Transactions Benchmark Results

Benchmark Report:
+-------------+-----+-----+--------+---------------+---------------+---------------+-----------------------+----------------------------+
| duration(s) | tps | cps | error% | latency (min) | latency (p50) | latency (p99) | gas used (MIST total) | gas used/hr (MIST approx.) |
+=======================================================================================================================================+
| 60          | 999 | 999 | 0      | 14            | 25            | 39            | 802,900,992,000       | 48,174,059,520,000         |
Stress Performance Report:
+-----------+-----+-----+
| metric    | p50 | p99 |
+=======================+
| cpu usage | 39  | 48  |

4 Validators 500/s Shared Transactions Benchmark Results

Benchmark Report:
+-------------+-----+-----+--------+---------------+---------------+---------------+-----------------------+----------------------------+
| duration(s) | tps | cps | error% | latency (min) | latency (p50) | latency (p99) | gas used (MIST total) | gas used/hr (MIST approx.) |
+=======================================================================================================================================+
| 60          | 993 | 993 | 0      | 14            | 278           | 448           | 960,147,193,200       | 57,608,831,592,000         |
Stress Performance Report:
+-----------+-----+-----+
| metric    | p50 | p99 |
+=======================+
| cpu usage | 44  | 55  |

20 Validators 50/s Owned Transactions Benchmark Results

Benchmark Report:
+-------------+-----+-----+--------+---------------+---------------+---------------+-----------------------+----------------------------+
| duration(s) | tps | cps | error% | latency (min) | latency (p50) | latency (p99) | gas used (MIST total) | gas used/hr (MIST approx.) |
+=======================================================================================================================================+
| 60          | 200 | 200 | 0      | 29            | 77            | 132           | 160,656,384,000       | 9,639,383,040,000          |
Stress Performance Report:
+-----------+-----+-----+
| metric    | p50 | p99 |
+=======================+
| cpu usage | 49  | 64  |

20 Validators 50/s Shared Transactions Benchmark Results

Benchmark Report:
+-------------+-----+-----+--------+---------------+---------------+---------------+-----------------------+----------------------------+
| duration(s) | tps | cps | error% | latency (min) | latency (p50) | latency (p99) | gas used (MIST total) | gas used/hr (MIST approx.) |
+=======================================================================================================================================+
| 60          | 197 | 197 | 0      | 71            | 585           | 1020          | 190,216,705,200       | 11,413,002,312,000         |
Stress Performance Report:
+-----------+-----+-----+
| metric    | p50 | p99 |
+=======================+
| cpu usage | 52  | 73  |

Narwhal Benchmark Results

 SUMMARY:
-----------------------------------------
 + CONFIG:
 Faults: 0 node(s)
 Committee size: 4 node(s)
 Worker(s) per node: 1 worker(s)
 Collocate primary and workers: True
 Input rate: 50,000 tx/s
 Transaction size: 512 B
 Execution time: 0 s

 Header number of batches threshold: 32 digests
 Header maximum number of batches: 1,000 digests
 Max header delay: 2,000 ms
 GC depth: 50 round(s)
 Sync retry delay: 10,000 ms
 Sync retry nodes: 3 node(s)
 batch size: 500,000 B
 Max batch delay: 200 ms
 Max concurrent requests: 500,000 

 + RESULTS:
 Batch creation avg latency: 202 ms
 Header creation avg latency: -1 ms
 	Batch to header avg latency: -1 ms
 Header to certificate avg latency: 2 ms
 	Request vote outbound avg latency: 0 ms
 Certificate commit avg latency: 848 ms

 Consensus TPS: 0 tx/s
 Consensus BPS: 0 B/s
 Consensus latency: 0 ms

 End-to-end TPS: 0 tx/s
 End-to-end BPS: 0 B/s
 End-to-end latency: 0 ms
-----------------------------------------

Please sign in to comment.