Skip to content

Commit

Permalink
Check for PR number before running release notes check (#19256)
Browse files Browse the repository at this point in the history
## Description 
Check for PR number before running release notes check

## Test plan 
👀
  • Loading branch information
ebmifa authored Sep 6, 2024
1 parent 47ad468 commit 5928a0d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/validate-release-notes-pre-land.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ concurrency:
jobs:
diff:
name: Determine PR eligibility for ${{ github.event.pull_request.number }}
if: github.event.pull_request.number != ''
runs-on: [ ubuntu-latest ]
outputs:
isReleaseNotesEligible: ${{ steps.diff.outputs.isReleaseNotesEligible }}
Expand All @@ -39,7 +40,7 @@ jobs:
release-notes-description-check:
name: Validate Release Notes in ${{ github.event.pull_request.number }}
needs: diff
if: needs.diff.outputs.isReleaseNotesEligible == 'true'
if: needs.diff.outputs.isReleaseNotesEligible == 'true' && github.event.pull_request.number != ''
runs-on: [ ubuntu-latest ]
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # Pin v4.1.1
Expand Down

0 comments on commit 5928a0d

Please sign in to comment.