Skip to content

Add single byte constructor to ObjectId #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xh3rman
Copy link

@0xh3rman 0xh3rman commented Mar 21, 2025

Thanks @bmwill for your guidance in draft pr: #104, I managed to compile our implementation using sui-sdk-types and sui-transaction-builder 🙏

Will test to see if any functionality breaks later

Can we add 2 simple constructors to build Address or ObjectId from single byte? this is equivalent to ObjectID::from_single_byte in sui-types.

@0xh3rman 0xh3rman requested a review from bmwill as a code owner March 21, 2025 07:41
@unmaykr-aftermath
Copy link
Contributor

@0xh3rman you may find useful our const-ructor for ObjectId (there's one for Address too). Here's how it's used.

@0xh3rman
Copy link
Author

@0xh3rman you may find useful our const-ructor for ObjectId (there's one for Address too). Here's how it's used.

But this is another crate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants