Refactor + use existing functions #886
Open
+173
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-lj
force-pushed
the
jonas/simplifications
branch
from
99a5ee0 to
415eab2
Compare
benr-ml
reviewed
Nov 20, 2025
|
|
||
| let lagrange_coefficients = Self::get_lagrange_coefficients_for( | ||
| index.get() as u128, | ||
| points.len() as u16, |
Contributor
There was a problem hiding this comment.
what if we have more than t points?
Contributor
Author
There was a problem hiding this comment.
It's up to the caller to only give t points - same as for recover_c0. I'm not sure I understand the need for the t parameter in those function since all it's doing is check that the given number of points is t?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_lagrange_coefficientsfunction forinterpolate_at_indexand rename torecover_at. This gives a significant speed-up (~65%).