feat: cache dirs::data_dir
and dirs::cache_dir
#659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intel vtune says
dirs::data_dir
anddirs::cache_dir
make syscall on windows for each check existence of package files. This is a disaster on large packages.With caching, the time used of
tinymist query packageDocs --id @preview/cetz:0.2.2
goes down from 0.9s to 0.7s.Intel vtune also says
sys::stat
syscall takes 0.2s to check existence of package files, but this need more careful cache strategy.Though we currently don't response changes of these two cached directory paths, it is less likely to be changed in application wide.