Skip to content

Fixed loco documentation #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Conversation

elladyr
Copy link
Collaborator

@elladyr elladyr commented Sep 22, 2024

  • Fixed environment names in Loco documentation
  • Added more info on the OSL interaction functions

Copy link
Collaborator

@Vittorio-Caggiano Vittorio-Caggiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Small nit

More details of the functions are here below:

- upload_osl_param(dict_of_dict) `upload_osl_param <https://github.com/MyoHub/myosuite/blob/main/myosuite/envs/myo/myochallenge/run_track_v0.py#L717>`__
- This function expects a dictionary of dictionary containing state parameter values
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those nested dictionaries?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. They are nested dictionaries. I was using a list as a top level structure initially, but thought it would be a better idea to use a consistent data type for key based indexing.

@Vittorio-Caggiano Vittorio-Caggiano merged commit 0deb2c2 into MyoHub:dev Sep 22, 2024
ttktjmt pushed a commit to ttktjmt/myosuite that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants