Skip to content

Run track p2 #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 12, 2024
Merged

Run track p2 #226

merged 10 commits into from
Sep 12, 2024

Conversation

P-Schumacher
Copy link
Collaborator

No description provided.

Vittorio-Caggiano
Vittorio-Caggiano approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@Vittorio-Caggiano Vittorio-Caggiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
just two suggestions:

  1. [major] add a test for the application (and reproducibility) of the terrains
  2. [minor] change the indication of the composite msk model from MyoAgent to something else

myosuite/envs/myo/assets/leg/myoosl_runtrack_p2.xml Outdated

<camera name="side_view" pos="-3 0 2.25" xyaxes="0 -1 0 1 0 2" mode="trackcom"/>

<!-- ======= MyoAgent ======= -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we standardized on this but Agent might indicate more the controller. I would say MyoActor or MyoBody to indicate only the body/actuation side

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has been addressed

@P-Schumacher
Copy link
Collaborator Author

lgtm. just two suggestions:

  1. [major] add a test for the application (and reproducibility) of the terrains
  2. [minor] change the indication of the composite msk model from MyoAgent to something else

Changed the name in the xml and added a test_heightfields.py file.

@Vittorio-Caggiano
Copy link
Collaborator

lgtm. just two suggestions:

  1. [major] add a test for the application (and reproducibility) of the terrains
  2. [minor] change the indication of the composite msk model from MyoAgent to something else

Changed the name in the xml and added a test_heightfields.py file.

thanks Pierre!

@P-Schumacher P-Schumacher merged commit 30426e2 into MyoHub:mc24_p2 Sep 12, 2024
ttktjmt pushed a commit to ttktjmt/myosuite that referenced this pull request Feb 12, 2025
@P-Schumacher
Merge pull request MyoHub#226 from P-Schumacher/run_track_p2
fc6f690 
Run track p2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vittorio-Caggiano Vittorio-Caggiano Vittorio-Caggiano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@P-Schumacher @Vittorio-Caggiano