Skip to content

MyoChallenge Locomotion metrics #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Sep 7, 2024
Merged

Conversation

elladyr
Copy link
Collaborator

@elladyr elladyr commented Aug 26, 2024

  1. Added metrics calculations for, distance, effort and pain
  2. Fixed OSL leg load sensor sign to fit default state machine parameters

@elladyr elladyr changed the title MyoChallenge metrics MyoChallenge Locomotion metrics Aug 26, 2024
@@ -51,6 +51,12 @@ class RunTrack(WalkEnvV0):
OSL_PARAM_LIST = []
OSL_PARAM_SELECT = 0

# Joint dict
pain_jnt = ['hip_adduction_l', 'hip_adduction_r', 'hip_flexion_l', 'hip_flexion_r', 'hip_rotation_l', 'hip_rotation_r',
'knee_angle_l', 'knee_angle_l_beta_rotation1', 'knee_angle_l_beta_translation1', 'knee_angle_l_beta_translation2',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the pain measure also needed for the translation joints?

Copy link
Collaborator Author

@elladyr elladyr Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean. Maybe translation joints are not suitable if we are using joint overextension. I was trying to model the impact pain, for example, stomping the foot or putting all the weight on one leg, would create a large force on the knee in the vertical axis.

I think for this context, let's go with only hinge joint overextensions. I will remove the translation joints and also remove the calculations for the knee cap translations

@@ -449,6 +471,14 @@ def _get_fallen_condition(self):
else:
return 0

def get_limitfrc(self, joint_name):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add documentation why this measurement is related to pain and why it is calculated in this way?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function calculates joint overextension force based on how much the joint limits are violated, and assumes that violating joint limits would create discomfort and pain. I can put that into the documentation

Copy link
Collaborator

@Vittorio-Caggiano Vittorio-Caggiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vittorio-Caggiano Vittorio-Caggiano changed the base branch from dev to mc24_p2 August 30, 2024 18:40
Copy link
Collaborator

@Vittorio-Caggiano Vittorio-Caggiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vittorio-Caggiano Vittorio-Caggiano merged commit a9cb246 into MyoHub:mc24_p2 Sep 7, 2024
ttktjmt pushed a commit to ttktjmt/myosuite that referenced this pull request Feb 12, 2025
MyoChallenge Locomotion metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants