Skip to content

MD5 not secure. Now it should be SHA512 by default #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

MD5 not secure. Now it should be SHA512 by default #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ffd4b6
MD5 not secure. Now it should be SHA512 by default
gothicx Apr 28, 2016
127b022
Adapt to the default password hash algo
gothicx Apr 28, 2016
96a9c0e
Support more than one NIS server
gothicx Apr 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
# NIS Domain
#
# [*nisserver*]
# NIS Server
# NIS Server. Pass a string or an array.
#
# [*shadow*]
# Enable shadow password
Expand Down Expand Up @@ -148,7 +148,7 @@
$nis = false,
$nisdomain = undef,
$nisserver = undef,
$passalgo = 'md5',
$passalgo = 'sha512',
$shadow = true,
$krb5 = false,
$krb5realm = undef,
Expand Down Expand Up @@ -277,16 +277,13 @@
$nisdomain_val = "--nisdomain=${nisdomain}"
}

if $nisserver {
if (is_array($nisserver)) {
$niss_joined = join($nisserver, ',')
$nisserver_val = "--nisserver=${niss_joined}"
} else {
$nisserver_val = "--nisserver=${nisserver}"
}

# MD5
$md5_flg = $passalgo ? {
'md5' => '--enablemd5',
default => '--disablemd5',
}

# hash/crypt algorithm for new passwords
if $passalgo {
$passalgo_val = "--passalgo=${passalgo}"
Expand Down Expand Up @@ -482,7 +479,7 @@

$extra_flags = "${preferdns_flg} ${forcelegacy_flg} ${pamaccess_flg}"

$pass_flags = "${md5_flg} ${passalgo_val} ${shadow_flg}"
$pass_flags = "${passalgo_val} ${shadow_flg}"
$authconfig_flags = "${ldap_flags} ${nis_flags} ${pass_flags} ${krb5_flags} ${winbind_flags} ${extra_flags} ${cache_flg} ${mkhomedir_flg} ${sssd_flg} ${sssdauth_flg} ${rfc2307bis_flg} ${locauthorize_flg} ${sysnetauth_flg} ${smartcard_flags}"
$authconfig_update_cmd = "authconfig ${authconfig_flags} --updateall"
$authconfig_test_cmd = "authconfig ${authconfig_flags} --test"
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/authconfig_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
{
'nis' => false,
'shadow' => true,
'passalgo' => 'md5',
'passalgo' => 'sha512',
}
end

Expand Down