-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove osc-min
dependency
#115
Comments
MylesBorins
added a commit
that referenced
this issue
Aug 9, 2024
Related to #115 Remove the `osc-min` dependency and implement `toBuffer` and `fromBuffer` functions directly. * **package.json** - Remove the `osc-min` dependency. * **lib/Client.mjs** - Implement the `toBuffer` function directly in this file. - Replace the import of `osc-min` with the new `toBuffer` function. * **lib/internal/decode.mjs** - Implement the `fromBuffer` function directly in this file. - Replace the import of `osc-min` with the new `fromBuffer` function. * **rollup.config.mjs** - Remove `osc-min` from the external dependencies. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/MylesBorins/node-osc/issues/115?shareId=XXXX-XXXX-XXXX-XXXX).
MylesBorins
added a commit
that referenced
this issue
Aug 9, 2024
Related to #115 Remove the `osc-min` dependency and implement custom OSC encoding/decoding functions. * **Remove `osc-min` dependency** - Remove `osc-min` from `package.json`. - Remove `#decode` alias from `package.json`. * **Update `Client.mjs`** - Import `toBuffer` from `internal/osc.mjs`. - Update `send` method to use the new `toBuffer` function. * **Update `Server.mjs`** - Import `fromBuffer` from `internal/osc.mjs`. - Update `message` event handler to use the new `fromBuffer` function. * **Add `internal/osc.mjs`** - Implement `toBuffer` function to encode OSC messages. - Implement `fromBuffer` function to decode OSC messages. * **Update `rollup.config.mjs`** - Remove `osc-min` and `#decode` from the `external` array in the `walkLib` function. - Remove `osc-min` and `#decode` from the `external` array in the `walkTest` function. * **Add tests for new implementation** - Add `test/test-osc.mjs` with tests for `toBuffer` and `fromBuffer` functions. * **Remove old files** - Delete `lib/internal/decode.mjs`. - Delete `test/test-decode.mjs`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/MylesBorins/node-osc/issues/115?shareId=XXXX-XXXX-XXXX-XXXX).
MylesBorins
added a commit
that referenced
this issue
Aug 20, 2024
Fixes #115 Remove the `osc-min` dependency and implement `toBuffer` and `fromBuffer` functions according to the OSC specification. * **package.json** - Remove the `osc-min` dependency. - Update the `imports` section to include `#osc` pointing to `internal/osc.mjs`. * **lib/Client.mjs** - Remove the import of `osc-min`. - Import `toBuffer` from `#osc`. - Update the `send` method to use `toBuffer` from `#osc`. * **lib/Server.mjs** - Remove the import of `#decode`. - Import `fromBuffer` from `#osc`. - Update the `_sock.on('message')` handler to use `fromBuffer` from `#osc`. * **internal/osc.mjs** - Implement the `toBuffer` function according to the OSC specification. - Implement the `fromBuffer` function according to the OSC specification. * **test/test-osc.mjs** - Add unit tests for `toBuffer` function. - Add unit tests for `fromBuffer` function. * **rollup.config.mjs** - Remove `osc-min` from the `external` array in the `walkLib` and `walkTest` functions. - Add `#osc` to the `external` array in the `walkLib` and `walkTest` functions. * **lib/internal/decode.mjs** - Delete the file. * **test/test-decode.mjs** - Delete the file. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/MylesBorins/node-osc/issues/115?shareId=XXXX-XXXX-XXXX-XXXX).
MylesBorins
added a commit
that referenced
this issue
Aug 28, 2024
Fixes #115 Remove the `osc-min` dependency and implement `toBuffer` and `fromBuffer` functions according to the OSC specification. * **package.json** - Remove the `osc-min` dependency - Add a package import named `#osc` pointing to `lib/internal/osc.mjs` * **lib/internal/osc.mjs** - Implement the `toBuffer` function - Implement the `fromBuffer` function * **lib/Client.mjs** - Remove the import of `osc-min` - Import `toBuffer` from `#osc` - Update the `send` method to use `toBuffer` from `#osc` * **lib/Server.mjs** - Remove the import of `#decode` - Import `fromBuffer` from `#osc` - Update the `_sock.on('message')` handler to use `fromBuffer` from `#osc` * **test/test-osc.mjs** - Add tests for the `toBuffer` function - Add tests for the `fromBuffer` function * **Remove files** - `lib/internal/decode.mjs` - `test/test-decode.mjs` --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/MylesBorins/node-osc/issues/115?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Currently
node-osc
relies on the packageosc-min
for it's exported functionalitytoBuffer
andfromBuffer
to encode and decode OSC messages. The library has not been updated in 5 years and is written in coffee script. Replacing it feels like a good idea.Implement an implementation of the API definition below using the OSC spec also found below. The two functions should be implemented in an
lib/internal/osc.mjs
file, included in the package.json as a package import named#osc
and have 100% test coverage.lib/internal/decode
should be removed.API Definitions
.fromBuffer(buffer, [strict])
takes a node.js Buffer of a complete OSC Packet and outputs the javascript representation, or throws if the buffer is ill-formed.
strict is an optional parameter that makes the function fail more often.
.toBuffer(object, [strict])
takes a OSC packet javascript representation as defined below and returns a node.js Buffer, or throws if the representation is ill-formed.
See "JavaScript representations of the OSC types" below.
Spec
From https://opensoundcontrol.stanford.edu/spec-1_0.html
Details
Introduction
Open Sound Control (OSC) is an open, transport-independent, message-based protocol developed for communication among computers, sound synthesizers, and other multimedia devices.
OSC Syntax
This section defines the syntax of OSC data.
Atomic Data Types
All OSC data is composed of the following fundamental data types:
The size of every atomic data type in OSC is a multiple of 32 bits. This guarantees that if the beginning of a block of OSC data is 32-bit aligned, every number in the OSC data will be 32-bit aligned.
OSC Packets
The unit of transmission of OSC is an OSC Packet. Any application that sends OSC Packets is an OSC Client; any application that receives OSC Packets is an OSC Server.
An OSC packet consists of its contents , a contiguous block of binary data, and its size , the number of 8-bit bytes that comprise the contents. The size of an OSC packet is always a multiple of 4.
The underlying network that delivers an OSC packet is responsible for delivering both the contents and the size to the OSC application. An OSC packet can be naturally represented by a datagram by a network protocol such as UDP. In a stream-based protocol such as TCP, the stream should begin with an int32 giving the size of the first packet, followed by the contents of the first packet, followed by the size of the second packet, etc.
The contents of an OSC packet must be either an OSC Message or an OSC Bundle. The first byte of the packet’s contents unambiguously distinguishes between these two alternatives.
OSC Messages
An OSC message consists of an OSC Address Pattern followed by an OSC Type Tag String followed by zero or more OSC Arguments.
Note: some older implementations of OSC may omit the OSC Type Tag string. Until all such implementations are updated, OSC implementations should be robust in the case of a missing OSC Type Tag String.
OSC Address Patterns
An OSC Address Pattern is an OSC-string beginning with the character ‘
/
’ (forward slash).OSC Type Tag String
An OSC Type Tag String is an OSC-string beginning with the character ‘
,
’ (comma) followed by a sequence of characters corresponding exactly to the sequence of OSC Arguments in the given message. Each character after the comma is called an OSC Type Tag and represents the type of the corresponding OSC Argument. (The requirement for OSC Type Tag Strings to start with a comma makes it easier for the recipient of an OSC Message to determine whether that OSC Message is lacking an OSC Type Tag String.)This table lists the correspondance between each OSC Type Tag and the type of its corresponding OSC Argument:
OSC Type Tag | Type of corresponding argument -- | -- i | int32 f | float32 s | OSC-string b | OSC-blobThe OSC Address of an OSC Method is a symbolic name giving the full path to the OSC Method in the OSC Address Space, starting from the root of the tree. An OSC Method’s OSC Address begins with the character ‘
/
’ (forward slash), followed by the names of all the containers, in order, along the path from the root of the tree to the OSC Method, separated by forward slash characters, followed by the name of the OSC Method. The syntax of OSC Addresses was chosen to match the syntax of URLs. (OSC Address Examples)OSC Message Dispatching and Pattern Matching
When an OSC server receives an OSC Message, it must invoke the appropriate OSC Methods in its OSC Address Space based on the OSC Message’s OSC Address Pattern. This process is called dispatching the OSC Message to the OSC Methods that match its OSC Address Pattern. All the matching OSC Methods are invoked with the same argument data, namely, the OSC Arguments in the OSC Message.
The parts of an OSC Address or an OSC Address Pattern are the substrings between adjacent pairs of forward slash characters and the substring after the last forward slash character. (examples)
A received OSC Message must be disptched to every OSC method in the current OSC Address Space whose OSC Address matches the OSC Message’s OSC Address Pattern. An OSC Address Pattern matches an OSC Address if
A part of an OSC Address Pattern matches a part of an OSC Address if every consecutive character in the OSC Address Pattern matches the next consecutive substring of the OSC Address and every character in the OSC Address is matched by something in the OSC Address Pattern. These are the matching rules for characters in the OSC Address Pattern:
?
’ in the OSC Address Pattern matches any single character*
’ in the OSC Address Pattern matches any sequence of zero or more characters[string]
”) in the OSC Address Pattern matches any character in the string. Inside square brackets, the minus sign (-
) and exclamation point (!
) have special meanings:{foo,bar}
”) in the OSC Address Pattern matches any of the strings in the list.Temporal Semantics and OSC Time Tags
An OSC server must have access to a representation of the correct current absolute time. OSC does not provide any mechanism for clock synchronization.
When a received OSC Packet contains only a single OSC Message, the OSC Server should invoke the correponding OSC Methods immediately, i.e., as soon as possible after receipt of the packet. Otherwise a received OSC Packet contains an OSC Bundle, in which case the OSC Bundle’s OSC Time Tag determines when the OSC Bundle’s OSC Messages’ corresponding OSC Methods should be invoked. If the time represented by the OSC Time Tag is before or equal to the current time, the OSC Server should invoke the methods immediately (unless the user has configured the OSC Server to discard messages that arrive too late). Otherwise the OSC Time Tag represents a time in the future, and the OSC server must store the OSC Bundle until the specified time and then invoke the appropriate OSC Methods.
Time tags are represented by a 64 bit fixed point number. The first 32 bits specify the number of seconds since midnight on January 1, 1900, and the last 32 bits specify fractional parts of a second to a precision of about 200 picoseconds. This is the representation used by Internet NTP timestamps.The time tag value consisting of 63 zero bits followed by a one in the least signifigant bit is a special case meaning “immediately.”
OSC Messages in the same OSC Bundle are atomic; their corresponding OSC Methods should be invoked in immediate succession as if no other processing took place between the OSC Method invocations.
When an OSC Address Pattern is dispatched to multiple OSC Methods, the order in which the matching OSC Methods are invoked is unspecified. When an OSC Bundle contains multiple OSC Messages, the sets of OSC Methods corresponding to the OSC Messages must be invoked in the same order as the OSC Messages appear in the packet. (example)
When bundles contain other bundles, the OSC Time Tag of the enclosed bundle must be greater than or equal to the OSC Time Tag of the enclosing bundle. The atomicity requirement for OSC Messages in the same OSC Bundle does not apply to OSC Bundles within an OSC Bundle.
Introduction Open Sound Control (OSC) is an open, transport-independent, message-based protocol developed for communication among computers, sound synthesizers, and other multimedia devices.OSC Syntax
This section defines the syntax of OSC data.
Atomic Data Types
All OSC data is composed of the following fundamental data types:
int32
32-bit big-endian two’s complement integer
OSC-timetag
64-bit big-endian fixed-point time tag, semantics defined below
float32
32-bit big-endian IEEE 754 floating point number
OSC-string
A sequence of non-null ASCII characters followed by a null, followed by 0-3 additional null characters to make the total number of bits a multiple of 32. (OSC-string examples) In this document, example OSC-strings will be written without the null characters, surrounded by double quotes.
OSC-blob
An int32 size count, followed by that many 8-bit bytes of arbitrary binary data, followed by 0-3 additional zero bytes to make the total number of bits a multiple of 32.
The size of every atomic data type in OSC is a multiple of 32 bits. This guarantees that if the beginning of a block of OSC data is 32-bit aligned, every number in the OSC data will be 32-bit aligned.
OSC Packets
The unit of transmission of OSC is an OSC Packet. Any application that sends OSC Packets is an OSC Client; any application that receives OSC Packets is an OSC Server.
An OSC packet consists of its contents , a contiguous block of binary data, and its size , the number of 8-bit bytes that comprise the contents. The size of an OSC packet is always a multiple of 4.
The underlying network that delivers an OSC packet is responsible for delivering both the contents and the size to the OSC application. An OSC packet can be naturally represented by a datagram by a network protocol such as UDP. In a stream-based protocol such as TCP, the stream should begin with an int32 giving the size of the first packet, followed by the contents of the first packet, followed by the size of the second packet, etc.
The contents of an OSC packet must be either an OSC Message or an OSC Bundle. The first byte of the packet’s contents unambiguously distinguishes between these two alternatives.
OSC Messages
An OSC message consists of an OSC Address Pattern followed by an OSC Type Tag String followed by zero or more OSC Arguments.
Note: some older implementations of OSC may omit the OSC Type Tag string. Until all such implementations are updated, OSC implementations should be robust in the case of a missing OSC Type Tag String.
OSC Address Patterns
An OSC Address Pattern is an OSC-string beginning with the character ‘/’ (forward slash).
OSC Type Tag String
An OSC Type Tag String is an OSC-string beginning with the character ‘,’ (comma) followed by a sequence of characters corresponding exactly to the sequence of OSC Arguments in the given message. Each character after the comma is called an OSC Type Tag and represents the type of the corresponding OSC Argument. (The requirement for OSC Type Tag Strings to start with a comma makes it easier for the recipient of an OSC Message to determine whether that OSC Message is lacking an OSC Type Tag String.)
This table lists the correspondance between each OSC Type Tag and the type of its corresponding OSC Argument:
The meaning of each OSC Type Tag
OSC Type Tag Type of corresponding argument
i int32
f float32
s OSC-string
b OSC-blob
Some OSC applications communicate among instances of themselves with additional, nonstandard argument types beyond those specified above. OSC applications are not required to recognize these types; an OSC application should discard any message whose OSC Type Tag String contains any unrecognized OSC Type Tags. An application that does use any additional argument types must encode them with the OSC Type Tags in this table:
OSC Type Tags that must be used for certain nonstandard argument types
OSC Type Tag Type of corresponding argument
h 64 bit big-endian two’s complement integer
t OSC-timetag
d 64 bit (“double”) IEEE 754 floating point number
S Alternate type represented as an OSC-string (for example, for systems that differentiate “symbols” from “strings”)
c an ascii character, sent as 32 bits
r 32 bit RGBA color
m 4 byte MIDI message. Bytes from MSB to LSB are: port id, status byte, data1, data2
T True. No bytes are allocated in the argument data.
F False. No bytes are allocated in the argument data.
N Nil. No bytes are allocated in the argument data.
I Infinitum. No bytes are allocated in the argument data.
[ Indicates the beginning of an array. The tags following are for data in the Array until a close brace tag is reached.
] Indicates the end of an array.
OSC Type Tag String examples.
OSC Arguments
A sequence of OSC Arguments is represented by a contiguous sequence of the binary representations of each argument.
OSC Bundles
An OSC Bundle consists of the OSC-string “#bundle” followed by an OSC Time Tag , followed by zero or more OSC Bundle Elements. The OSC-timetag is a 64-bit fixed point time tag whose semantics are described below.
An OSC Bundle Element consists of its size and its contents. The size is an int32 representing the number of 8-bit bytes in the contents, and will always be a multiple of 4. The contents are either an OSC Message or an OSC Bundle.
Note this recursive definition: bundle may contain bundles.
This table shows the parts of a two-or-more-element OSC Bundle and the size (in 8-bit bytes) of each part.
Parts of an OSC Bundle
Data Size Purpose
OSC-string “#bundle” 8 bytes How to know that this data is a bundle
OSC-timetag 8 bytes Time tag that applies to the entire bundle
Size of first bundle element int32 = 4 bytes
First bundle element’s contents As many bytes as given by “size of first bundle element” First bundle element
Size of second bundle element int32 = 4 bytes
Second bundle element’s contents As many bytes as given by “size of second bundle element” Second bundle element
etc. Addtional bundle elements
OSC Semantics
This section defines the semantics of OSC data.
OSC Address Spaces and OSC Addresses
Every OSC server has a set of OSC Methods. OSC Methods are the potential destinations of OSC messages received by the OSC server and correspond to each of the points of control that the application makes available. “Invoking” an OSC method is analogous to a procedure call; it means supplying the method with arguments and causing the method’s effect to take place.
An OSC Server’s OSC Methods are arranged in a tree strcuture called an OSC Address Space. The leaves of this tree are the OSC Methods and the branch nodes are called OSC Containers. An OSC Server’s OSC Address Space can be dynamic; that is, its contents and shape can change over time.
Each OSC Method and each OSC Container other than the root of the tree has a symbolic name, an ASCII string consiting of printable characters other than the following:
Printable ASCII characters not allowed in names of OSC Methods or OSC Containers
character name ASCII code (decimal)
’ ’ space
number sign 35
, comma 44
/ forward slash 47
? question mark 63
[ open bracket 91
] close bracket 93
{ open curly brace 123
} close curly brace 125
The OSC Address of an OSC Method is a symbolic name giving the full path to the OSC Method in the OSC Address Space, starting from the root of the tree. An OSC Method’s OSC Address begins with the character ‘/’ (forward slash), followed by the names of all the containers, in order, along the path from the root of the tree to the OSC Method, separated by forward slash characters, followed by the name of the OSC Method. The syntax of OSC Addresses was chosen to match the syntax of URLs. (OSC Address Examples)
OSC Message Dispatching and Pattern Matching
When an OSC server receives an OSC Message, it must invoke the appropriate OSC Methods in its OSC Address Space based on the OSC Message’s OSC Address Pattern. This process is called dispatching the OSC Message to the OSC Methods that match its OSC Address Pattern. All the matching OSC Methods are invoked with the same argument data, namely, the OSC Arguments in the OSC Message.
The parts of an OSC Address or an OSC Address Pattern are the substrings between adjacent pairs of forward slash characters and the substring after the last forward slash character. (examples)
A received OSC Message must be disptched to every OSC method in the current OSC Address Space whose OSC Address matches the OSC Message’s OSC Address Pattern. An OSC Address Pattern matches an OSC Address if
The OSC Address and the OSC Address Pattern contain the same number of parts; and
Each part of the OSC Address Pattern matches the corresponding part of the OSC Address.
A part of an OSC Address Pattern matches a part of an OSC Address if every consecutive character in the OSC Address Pattern matches the next consecutive substring of the OSC Address and every character in the OSC Address is matched by something in the OSC Address Pattern. These are the matching rules for characters in the OSC Address Pattern:
‘?’ in the OSC Address Pattern matches any single character
‘*’ in the OSC Address Pattern matches any sequence of zero or more characters
A string of characters in square brackets (e.g., “[string]”) in the OSC Address Pattern matches any character in the string. Inside square brackets, the minus sign (-) and exclamation point (!) have special meanings:
two characters separated by a minus sign indicate the range of characters between the given two in ASCII collating sequence. (A minus sign at the end of the string has no special meaning.)
An exclamation point at the beginning of a bracketed string negates the sense of the list, meaning that the list matches any character not in the list. (An exclamation point anywhere besides the first character after the open bracket has no special meaning.)
A comma-separated list of strings enclosed in curly braces (e.g., “{foo,bar}”) in the OSC Address Pattern matches any of the strings in the list.
Any other character in an OSC Address Pattern can match only the same character.
Temporal Semantics and OSC Time Tags
An OSC server must have access to a representation of the correct current absolute time. OSC does not provide any mechanism for clock synchronization.
When a received OSC Packet contains only a single OSC Message, the OSC Server should invoke the correponding OSC Methods immediately, i.e., as soon as possible after receipt of the packet. Otherwise a received OSC Packet contains an OSC Bundle, in which case the OSC Bundle’s OSC Time Tag determines when the OSC Bundle’s OSC Messages’ corresponding OSC Methods should be invoked. If the time represented by the OSC Time Tag is before or equal to the current time, the OSC Server should invoke the methods immediately (unless the user has configured the OSC Server to discard messages that arrive too late). Otherwise the OSC Time Tag represents a time in the future, and the OSC server must store the OSC Bundle until the specified time and then invoke the appropriate OSC Methods.
Time tags are represented by a 64 bit fixed point number. The first 32 bits specify the number of seconds since midnight on January 1, 1900, and the last 32 bits specify fractional parts of a second to a precision of about 200 picoseconds. This is the representation used by Internet NTP timestamps.The time tag value consisting of 63 zero bits followed by a one in the least signifigant bit is a special case meaning “immediately.”
OSC Messages in the same OSC Bundle are atomic; their corresponding OSC Methods should be invoked in immediate succession as if no other processing took place between the OSC Method invocations.
When an OSC Address Pattern is dispatched to multiple OSC Methods, the order in which the matching OSC Methods are invoked is unspecified. When an OSC Bundle contains multiple OSC Messages, the sets of OSC Methods corresponding to the OSC Messages must be invoked in the same order as the OSC Messages appear in the packet. (example)
When bundles contain other bundles, the OSC Time Tag of the enclosed bundle must be greater than or equal to the OSC Time Tag of the enclosing bundle. The atomicity requirement for OSC Messages in the same OSC Bundle does not apply to OSC Bundles within an OSC Bundle.
The text was updated successfully, but these errors were encountered: