Migrate installed skills file to XDG Base Directory #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureTryOut
commented
Dec 8, 2020
|
I also noticed that the pyxdg is only in requirements and not in setup.py |
forslund
reviewed
Dec 12, 2020
|
Suggested fix for the mocking issue: https://github.com/forslund/mycroft-skills-manager/tree/PureTryOut-xdg-config |
This was referenced Jan 8, 2021
forslund
requested changes
Jan 20, 2021
Combined with MycroftAI/mycroft-core#2578 ~/.mycroft/skills.json is now migrated to follow the XDG Base Directory specification. This means it'll be installed to $XDG_DATA_HOME/mycroft/skills.json, or $HOME/.local/share/mycroft/skills.json if $XDG_DATA_HOME is unset The file is migrated from the old location if it still exists there
forslund
approved these changes
Jan 20, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Combined with MycroftAI/mycroft-core#2578
~/.mycroft/skills.jsonis now migrated to follow the XDG Base Directoryspecification.
This means it'll be installed to
$XDG_DATA_HOME/mycroft/skills.json,or
$HOME/.local/share/mycroft/skills.jsonif$XDG_DATA_HOMEis unsetThe file is migrated from the old location if it still exists there
Type of PR
Testing
Run MSM at least once without this PR and without MycroftAI/mycroft-core#2578 and make sure
~/.mycroft/skills.jsonexists.Then run MyCroft and MSM with MycroftAI/mycroft-core#2578 and this PR, and verify that
~/.mycroft/skills.jsonhas been moved to~/.local/share/mycroft/skills.json(assuming you haven't changed$XDG_DATA_HOME) and that everything still works correctly as before.Documentation
No documentation updates are needed