Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XDG Base Directory compatible MSM #63

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Support XDG Base Directory compatible MSM #63

merged 2 commits into from
Jun 2, 2022

Conversation

PureTryOut
Copy link
Contributor

@PureTryOut PureTryOut commented Nov 4, 2021

Description

The SkillRepo object from MSM has changed and does not need a provided
path anymore, this adapts to that.

Resolves #62.

Type of PR

  • Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

Testing

Execute msk create with this PR and MSM 0.9.0 installed and see if it has created the new skill in ~/.local/share/mycroft/skills rather than /opt/mycroft/skills.

The SkillRepo object from MSM has changed and does not need a provided
path anymore, this adapts to that
JarbasAl
JarbasAl previously approved these changes Nov 4, 2021
@PureTryOut
Copy link
Contributor Author

@krisgesling could you look into this?

krisgesling
krisgesling previously approved these changes Jun 2, 2022
Copy link
Contributor

@krisgesling krisgesling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this seems to be working great.

New Skills created in the correct location and other commands require a path to the specific skill anyway.

@krisgesling
Copy link
Contributor

Just going to bump the version to 0.4

Matthew is no longer an active maintainer of this project.
I've removed his details so he doesn't get bugged about it.
@krisgesling krisgesling dismissed stale reviews from JarbasAl and themself via c7b6c4a June 2, 2022 01:09
@krisgesling krisgesling merged commit c6e5af9 into MycroftAI:master Jun 2, 2022
@PureTryOut PureTryOut deleted the xdg-base-directory branch June 2, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Support XDG compatible paths
3 participants