Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock version to supported msm-version #60

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Lock version to supported msm-version #60

merged 1 commit into from
Aug 23, 2021

Conversation

forslund
Copy link
Collaborator

Description

This is a quick fix for #59 msk should be updated accordingly but as the 0.9 version of msm hasn't been adopted quite yet I believe this is the best way to keep it synched with mycroft-core and the msm tool in use.

Type of PR

  • [ x ] Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

Testing

Check that a fresh install in a venv works out of the box by running (from the msk folder)

python3 -m venv venv
source venv/bin/activate
pip install .
msk create

and doesn't throw a TypeError

@krisgesling
Copy link
Contributor

Looks good, thanks Ake :)

@krisgesling krisgesling merged commit e3d6395 into MycroftAI:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants