Vk error stability #2793
Vk error stability #2793
Conversation
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
| @@ -83,8 +83,9 @@ def mycroft_responses(context): | |||
| if len(messages) > 0: | |||
| responses = 'Mycroft responded with:\n' | |||
| for m in messages: | |||
| print(m, m.data) | |||
There was a problem hiding this comment.
Leftover print statement that I assume was for temporary debugging and shouldn't be logged?
There was a problem hiding this comment.
Indeed, will remove
| expected_value (Object): The expected value indicating that the change | ||
| has been applied | ||
| """ | ||
| start_time = time.time() |
There was a problem hiding this comment.
It shouldn't cause a problem in this instance but I've been wondering if we should use time.monotonic() where ever possible for consistency and to avoid time sync issues?
Are there benefits of using the standard time.time()?
There was a problem hiding this comment.
I considered monotonic but thought the simplicity and readability of time.time() was better than using monotonic but I'll change it.
This can occur if a custom made speak message is injected and VK should handle malformed speak messages.
forslund
force-pushed
the
bugfix/vk-error-stability
branch
from
9eb6d47
to
83ed811
Compare
|
Updated as requested |
|
Voight Kampff Integration Test Failed (Results). |
|
Voight Kampff Integration Test Succeeded (Results) |
Description
While testing #2578 we ran into a couple of issues in VK not handling some error cases in Mycroft core.
This PR ensures that
How to test
Make sure Voight Kampff tests still pass. To check the timeout comment out lines 77 and 79 of
test/integrationtests/voight_kampff/features/steps/configuration.pyand run the tests for the fallback-query skill.Contributor license agreement signed?
CLA [ Yes ]