Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

[Debian] Replace Python 2 packages by their Python 3 counterparts and remove doubled "automake" #2167

Merged
merged 4 commits into from
Jun 25, 2019

Conversation

MichaIng
Copy link
Contributor

@MichaIng MichaIng commented Jun 18, 2019

Description

The aim is simply to skip installing Python 2 on Debian where only Python 3 is required. (Removal of the doubled automake package from dependency list is trivial. 😉)

The second one is not the -dev package. There is non available for Python 3 only, instead for both: https://packages.debian.org/stretch/python-gi-dev
However I tested with the above two on x86 and didn't notice any compilation (including Mimic) or related run error with Mycroft. However clearly needs additional testing on e.g. ARM devices in case, or knowledge of the devs who know where/how the GObject libs/headers are actually used.

So take this PR for now as an idea to think about skipping the install of Python 2 on Debian.

How to test

Install on Debian on different CPU architectures, where compilation might have different needs compared to x86.

Contributor license agreement signed?

@devs-mycroft devs-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Jun 18, 2019
@devs-mycroft
Copy link
Collaborator

Hello, @MichaIng, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@forslund
Copy link
Collaborator

Thanks for this, will merge as soon as the CLA gets in.

I don't think python3-gi is actually needed for core either and we should be able to remove that requirement all together.

@MichaIng
Copy link
Contributor Author

@forslund

Thanks for this, will merge as soon as the CLA gets in.

I filled the form already but didn't receive a confirmation email yet. This takes a while?

I don't think python3-gi is actually needed for core either and we should be able to remove that requirement all together.

Would be even better. Shall I remove it completely (on all distros) with this PR? Even as is, the PR should be tested on other architectures before merging, so then dependency on GObject could be tested all together.

@forslund
Copy link
Collaborator

There's some amount of manual labor involved in getting the CLA mails sent out so you should have the mail soon-ish. If it doesn't arrive in a day or two, check spam then yell at me and I'll look into it.

Just change it for debian/ubuntu and then we can create help-wanted issues for the other OS'es so it can be tested properly. (I currently only run Debian derivatives)

@MichaIng
Copy link
Contributor Author

MichaIng commented Jun 18, 2019

@forslund
Makes sense, same here with Debian-only distros running.

@MichaIng
Copy link
Contributor Author

Resolved conflict with new info print when pre-reqs are installed.

@devs-mycroft devs-mycroft added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Jun 24, 2019
@forslund
Copy link
Collaborator

CLA has arrived. Going to spin up a new Ubuntu VM and try this fresh! Thanks for contributing!

@forslund
Copy link
Collaborator

Tested and looks good! Merging!

@forslund forslund merged commit 7a2e58b into MycroftAI:dev Jun 25, 2019
@MichaIng MichaIng deleted the patch-2 branch June 25, 2019 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants