Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Extract STT and TTS base classes to packaged modules #2874

Closed
NeonDaniel opened this issue Mar 30, 2021 · 1 comment
Closed

Extract STT and TTS base classes to packaged modules #2874

NeonDaniel opened this issue Mar 30, 2021 · 1 comment

Comments

@NeonDaniel
Copy link
Member

Is your feature request related to a problem? Please describe.
STT and TTS plugins currently override base classes in mycroft-core. This requires plugins to be developed and used in an environment that includes all of mycroft-core and makes it more difficult to unit test plugins during development. This is a feature request that helps plugin developers better test STT/TTS engines available for use with mycroft-core

Describe the solution you'd like
Extracting the base classes to separate modules would allow them to be imported individually in plugin classes. Configuration could be passed when objects are created or else read from default locations.

Describe alternatives you've considered
There is currently support for this via ovos_utils (https://github.com/OpenVoiceOS/ovos_utils/blob/dev/ovos_utils/plugins/stt.py). Integrating this or something equivalent into the official Mycroft Core would allow developers to utilize an imported STT/TTS base class without worrying about future compatibility with mycroft core changes.

Additional context
This would be a similar concept as is being looked at for the messagebus-client here: #2863

@forslund
Copy link
Collaborator

forslund commented Sep 8, 2024

Closing Issue since we're archiving the repo

@forslund forslund closed this as completed Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants