feat/ovos_plugin_manager #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeonDaniel
requested changes
Oct 25, 2021
JarbasAl
force-pushed
the
dev
branch
3 times, most recently
from
1b15829
to
47d8a1f
Compare
JarbasAl
force-pushed
the
feat/ovos_plugin_manager
branch
2 times, most recently
from
56d3cec
to
b26a818
Compare
JarbasAl
added
refactor
JarbasAl
commented
Nov 3, 2021
| # TODO add ovos ocp + ovos vlc |
There was a problem hiding this comment.
this TODO is for a future PR, note that vlc and simple audio backends have not been removed by this PR
NeonDaniel
approved these changes
Nov 3, 2021
NeonDaniel
reviewed
Nov 3, 2021
| - name: Build Distribution Packages | ||
| run: | | ||
| python setup.py bdist_wheel | ||
| - name: Install tflite_runtime workaround tflit bug |
There was a problem hiding this comment.
maybe, there is one in the upstream tflit repo already, happens in some platforms due to some mismatch with post release version of the wheel it tries to download or something during setup.py
There was a problem hiding this comment.
Just want to make sure we remember to remove this when upstream gets fixed, though it's not a big deal just for automation
JarbasAl
force-pushed
the
feat/ovos_plugin_manager
branch
from
2f2ffb2
to
8c3b1af
Compare
JarbasAl
added a commit
that referenced
this pull request
Nov 4, 2021
authored-by: jarbasai <jarbasai@mailfence.com>
This was referenced Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes most hardcoded engines for hotwords/audio/tts/stt in favor of the plugin system
removes code for the XXFactory objects, now imported from ovos plugin manager
might make sense to hold on merging this until all engines have an equivalent plugin mapped in opm factory classes for full backwards compat. but given that most engines would already fail unless requirements were manually installed i dont think this matters. all defaults are accounted for
related issues: