Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Commit

Permalink
Update start-mycroft.sh
Browse files Browse the repository at this point in the history
  • Loading branch information
@el-tocino
el-tocino authored Jun 18, 2021
1 parent 5084de9 commit 63e7b60
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion start-mycroft.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ if [[ "${1}" == "restart" ]] || [[ "${_opt}" == "restart" ]] ; then
fi
_params=$@

if ! grep -i cli <<< "${_params}" ; then
if [[ ! "${_opt}" == "cli" ]] ; then
check-dependencies
fi

Expand Down

2 comments on commit 63e7b60

@PureTryOut
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, @krisgesling and @el-tocino can we please enforce better (more detailed) commit messages? I had to rebase #2686 on this and purely looking at the commits I couldn't figure out why this was changed. To be honest, I still don't (although I find the current code better readable so I'm assuming that's the reason).

Commit messages should in 1 line (the first line) tell what exactly has been changed. Any further lines in the message can be used to explain why the change was made and how to test it. "Update start-mycroft.sh" says exactly nothing about what changed, only that "something in start-mycroft.sh" changed, which is useless really.

@krisgesling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, fair call. There's more detail in the PR description here: #2715
but fully agree with your comment about the 1st line of a commit message

Please sign in to comment.