This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
63e7b60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch, @krisgesling and @el-tocino can we please enforce better (more detailed) commit messages? I had to rebase #2686 on this and purely looking at the commits I couldn't figure out why this was changed. To be honest, I still don't (although I find the current code better readable so I'm assuming that's the reason).
Commit messages should in 1 line (the first line) tell what exactly has been changed. Any further lines in the message can be used to explain why the change was made and how to test it. "Update start-mycroft.sh" says exactly nothing about what changed, only that "something in start-mycroft.sh" changed, which is useless really.
63e7b60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, fair call. There's more detail in the PR description here: #2715
but fully agree with your comment about the 1st line of a commit message