-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: extractnumber_xx API incompatibility #71
fix: extractnumber_xx API incompatibility #71
Conversation
Hello, @YuukanOO, thank you for helping with the Mycroft project! We welcome everyone To protect yourself, the project, and users of Mycroft technologies we require Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank |
Properly formatted, fixes an oversight (this fix made it to the Spanish parser, but none of the others.) @YuukanOO even carried the TODO over. What service! 💯 |
Really like this project and trying to implement the |
It's occurred to me that these should just |
I'll take care of that 👍 |
Thanks! I'll verify this when I'm back at a workstation, if nobody beats me to it. |
@YuukanOO I thought I commented on this at the time, but I guess I didn't hit submit. Your authorship got knocked off the commit in a botched attempt to migrate the branch before merging. If I'd realized that would happen, I would just have asked you to check the "contributors can modify" box, but I was clueless and wound up making your name go poof from the repo. However, there's a major refactor in process that touches these functions again. If it's good by you, I'd like to take the opportunity to put you back in |
Hi @ChanceNCounter ! Sounds good to me. Stuff like this can happen, not a problem 😉 Thanks for reporting it! |
User @Yuukan00 in PR MycroftAI#71 fixed a number of incompatibilities with non-English languages. Their commits were accidentally reassigned to another dev during a botched merge. This is to reintroduce them to git log, using GitHub's coauthorship feature. Co-authored by: YuukanOO <julien+github@leicher.me>
User @Yuukan00 in PR MycroftAI#71 fixed a number of incompatibilities with non-English languages. Their commits were accidentally reassigned to another dev during a botched merge. This is to reintroduce them to git log, using GitHub's coauthorship feature. Co-authored by: YuukanOO <julien+github@leicher.me>
User @Yuukan00 in PR MycroftAI#71 fixed a number of incompatibilities with non-English languages. Their commits were accidentally reassigned to another dev during a botched merge. This is to reintroduce them to git log, using GitHub's coauthorship feature. Co-authored by: YuukanOO <julien+github@leicher.me>
User @Yuukan00 in PR MycroftAI#71 fixed a number of incompatibilities with non-English languages. Their commits were accidentally reassigned to another dev during a botched merge. This is to reintroduce them to git log, using GitHub's coauthorship feature. Co-authored by: YuukanOO <julien+github@leicher.me>
User @Yuukan00 in PR MycroftAI#71 fixed a number of incompatibilities with non-English languages. Their commits were accidentally reassigned to another dev during a botched merge. This is to reintroduce them to git log, using GitHub's coauthorship feature. Co-authored-by: YuukanOO <julien+github@leicher.me>
User @Yuukan00 in PR MycroftAI#71 fixed a number of incompatibilities with non-English languages. Their commits were accidentally reassigned to another dev during a botched merge. This is to reintroduce them to git log, using GitHub's coauthorship feature. Co-authored-by: YuukanOO <julien+github@leicher.me>
For some languages, the definition of
extractnumber_xx
was incompatible with the use ofextract_numbers_generic
since it lacksshort_scale
andordinals
keyword args.This PR fix this.
It also updates the
extractnumber_fr
when no number has been found on the given text by returningFalse
instead of a normalized string to make it in sync with all otherextractnumber_xx
methods in other languages which return a number or False if no number has been parsed. Doing so handle cases such asextractnumbers('2 heures')
which failed otherwise.