Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

Supported OpenSSL 1.1.0 in windows #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sm2017
Copy link

@sm2017 sm2017 commented Oct 12, 2020

Since version 1.1.0 OpenSSL have changed their library names from: libeay32.dll -> libcrypto.dll

Since version 1.1.0 OpenSSL have changed their library names from: libeay32.dll -> libcrypto.dll
@coveralls
Copy link

coveralls commented Oct 12, 2020

Pull Request Test Coverage Report for Build 46

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 41: 0.0%
Covered Lines: 64
Relevant Lines: 64

💛 - Coveralls

@sm2017
Copy link
Author

sm2017 commented Oct 12, 2020

Temporary solution fatal error LNK1181: cannot open input file 'C:\OpenSSL-Win64\lib\libeay32.lib' until next version

cd c:/
mkdir OpenSSL-Win64/lib
cd OpenSSL-Win64/lib
cmd /c mklink .\libeay32.lib "C:\Program Files\OpenSSL-Win64\lib\libcrypto.lib"

@sm2017
Copy link
Author

sm2017 commented Oct 12, 2020

I'm not sure that my changes for OpenSSL-Win32 is correct or not

@kobim
Copy link
Member

kobim commented Oct 13, 2020

Hi @sm2017!
Thank you for your contribution and attention to the problem!

I have taken the liberty to add Windows (and macOS) tests to the CI (#30), and I found out there might be another approach to support both OpenSSL 1.0 and 1.1.
Would you be able to checkout that branch and test to see if the compilation works on your machine? If so, I'll release a new version with the update.

@sm2017
Copy link
Author

sm2017 commented Oct 18, 2020

@kobim I tested the branch by running yarn add MySiteApp/node-safari-push-notifications#deps/update it works well

@kobim
Copy link
Member

kobim commented Oct 28, 2020

Thank you @sm2017!
I just published v0.5.0 (06bd8bc) to npm with the changes you verified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants