[BUGFIX] Allow "Content-Type" in content #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a regular expression to determine whether the provided HTML contains a `Content-Type` `meta` element instead of just testing for the string "Content-Type". Also allow for case insensitivity. A valid `Content-Type` `meta` element which is invalidly placed (i.e. within the `body`) will still be determined to be valid. This will be addressed separately for #923. Add the package `rawr/cross-data-providers` to the development dependencies. This is useful to generate a matrix of combinations for test data providers. There are a few existing instances where this could be used to replace code effectively doing that, but which are not addressed in this commit. Rename affected data provider methods from `xyzDataProvider` to `provideXyx`, which is more succinct and a more commonly used nomenclature on other projects. Fixes #957.
oliverklee
requested changes
Mar 22, 2021
- More explicity test return value from `preg_match`; - Add tests that the regular expression does not match unexpected keywords of which the expected keywords are substrings.
|
I've changed the test for the |
JakeQZ
added a commit
that referenced
this pull request
Apr 11, 2021
Since the library `rawr/cross-data-providers` has been added as a development dependency (in #959), make use of it where applicable to combine datasets for tests. This makes the test data providers clearer and eliminates duplication of functionality.
JakeQZ
added a commit
that referenced
this pull request
Apr 11, 2021
Since the library `rawr/cross-data-providers` has been added as a development dependency (in #959), make use of it where applicable to combine datasets for tests. This makes the test data providers clearer and eliminates duplication of functionality.
JakeQZ
added a commit
that referenced
this pull request
Apr 11, 2021
Since the library `rawr/cross-data-providers` has been added as a development dependency (in #959), make use of it where applicable to combine datasets for tests. This makes the test data providers clearer and eliminates duplication of functionality.
oliverklee
pushed a commit
that referenced
this pull request
Apr 11, 2021
Since the library `rawr/cross-data-providers` has been added as a development dependency (in #959), make use of it where applicable to combine datasets for tests. This makes the test data providers clearer and eliminates duplication of functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a regular expression to determine whether the provided HTML contains a
Content-Typemetaelement instead of just testing for the string"Content-Type". Also allow for case insensitivity.
A valid
Content-Typemetaelement which is invalidly placed (i.e. within thebody) will still be determined to be valid. This will be addressed separatelyfor #923.
Add the package
rawr/cross-data-providersto the development dependencies.This is useful to generate a matrix of combinations for test data providers.
There are a few existing instances where this could be used to replace code
effectively doing that, but which are not addressed in this commit.
Rename affected data provider methods from
xyzDataProvidertoprovideXyx,which is more succinct and a more commonly used nomenclature on other projects.
Fixes #957.