[TASK] Drop support for Symfony 4.3 and 5.0 #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeQZ
requested changes
Nov 22, 2020
CHANGELOG.md
Outdated
| @@ -30,6 +30,9 @@ This project adheres to [Semantic Versioning](https://semver.org/). | |||
| - Support for PHP 7.1 will be removed in Emogrifier 6.0. | |||
|
|
|||
| ### Removed | |||
| - Drop support for Symfony 4.3 and 5.0 | |||
| ([#918](https://github.com/MyIntervals/emogrifier/pull/918), | |||
There was a problem hiding this comment.
URL should contain issues not pull (if required at all).
There was a problem hiding this comment.
Ah, damn copy'n'paste. Thanks for spotting these issues!
Symfony 4.3 and 5.0 are end-of-life now. Emogrifier still supports the Symfony LTS releases 3.4 and 4.4 as well as the currently supported non-LTS version 5.1 (and newer 5.x versions). Fixes #918
oliverklee
force-pushed
the
task/symfony-deps
branch
from
3fd3ff3
to
79ce40f
Compare
|
I have rebased and dropped the first URL. |
This makes the changelog a bit more concise.
oliverklee
force-pushed
the
task/symfony-deps
branch
from
79ce40f
to
839f5c7
Compare
JakeQZ
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 4.3 and 5.0 are end-of-life now.
Emogrifier still supports the Symfony LTS releases 3.4 and 4.4 as well
as the currently supported non-LTS version 5.1 (and newer 5.x versions).
Fixes #918