[TASK] Support PHP 8.0 #926
Conversation
|
Blocked by #924 at present, but will hopefully enough here to give insight as to whether there is anything else we need to do or fix. |
|
Lint passes, at least, and the checks seem to run fine against whatever RC/beta version is currently deployed by GitHub. |
|
Ah, but we need to update |
|
That's now resolved, but the I think we need to revert back to Composer for PHPUnit (i.e. revert #894), unless there's a way for Phive to handle this situation? |
|
@JakeQZ I've tested whether Phive allows parallel installation of multiple PHPUnit versions: It doesn't. However, we could manually add a |
Can we not run PS. The unit tests seem to complete without failure with PHPUnit 9.4, however there are a lot of warnings about deprecated assertion methods. |
|
Now have a green build :)) |
|
Will make a separate PR for the changes for PHPUnit & PHIVE... |
This is required to be able to test against PHP 8. However, PHPUnit 9.x requires PHP 7.3, so a different version of PHPUnit is required for different testing environments. The main change here is a step in the GitHub Action to conditionally update PHPUnit via PHIVE for PHP >=7.3. PHIVE does not yet have the ability for conditional installs (see phar-io/phive#295 (comment)) so the script must check the PHP version before running the update. PHIVE has also been added to the tools (self-referencing) as it is not available by default to GitHub Actions. Note: There are warnings from PHPUnit 9.x about use of deprecated `assert` methods (which will be removed in PHPUnit 10.x). However, these don't cause the tests to fail, and the replacement methods are not available in PHPUnit 7.x which is still required to test against PHP 7.1 and 7.2. Part of #925/#926.
This is required to be able to test against PHP 8. However, PHPUnit 9.x requires PHP 7.3, so a different version of PHPUnit is required for different testing environments. The main change here is a step in the GitHub Action to conditionally update PHPUnit via PHIVE for PHP >=7.3. PHIVE does not yet have the ability for conditional installs (see phar-io/phive#295 (comment)) so the script must check the PHP version before running the update. PHIVE has also been added to the tools (self-referencing) as it is not available by default to GitHub Actions. Note: There are warnings from PHPUnit 9.x about use of deprecated `assert` methods (which will be removed in PHPUnit 10.x). However, these don't cause the tests to fail, and the replacement methods are not available in PHPUnit 7.x which is still required to test against PHP 7.1 and 7.2. Part of #925/#926.
This is required to be able to test against PHP 8. However, PHPUnit 9.x requires PHP 7.3, so a different version of PHPUnit is required for different testing environments. The main change here is a step in the GitHub Action to conditionally update PHPUnit via PHIVE for PHP >=7.3. PHIVE does not yet have the ability for conditional installs (see phar-io/phive#295 (comment)) so the script must check the PHP version before running the update. PHIVE has also been added to the tools (self-referencing) as it is not available by default to GitHub Actions. Note: There are warnings from PHPUnit 9.x about use of deprecated `assert` methods (which will be removed in PHPUnit 10.x). However, these don't cause the tests to fail, and the replacement methods are not available in PHPUnit 7.x which is still required to test against PHP 7.1 and 7.2. Part of #925/#926.
This is required to be able to test against PHP 8. However, PHPUnit 9.x requires PHP 7.3, so a different version of PHPUnit is required for different testing environments. The main change here is a step in the GitHub Action to conditionally update PHPUnit via PHIVE for PHP >=7.3. PHIVE does not yet have the ability for conditional installs (see phar-io/phive#295 (comment)) so the script must check the PHP version before running the update. PHIVE has also been added to the tools (self-referencing) as it is not available by default to GitHub Actions. Note: There are warnings from PHPUnit 9.x about use of deprecated `assert` methods (which will be removed in PHPUnit 10.x). However, these don't cause the tests to fail, and the replacement methods are not available in PHPUnit 7.x which is still required to test against PHP 7.1 and 7.2. Part of #925/#926.
This should have been dropped by the rebase.
Resolves #925.