Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Move PHPMD to Phive #852

Merged
merged 1 commit into from
Mar 28, 2020
Merged

[TASK] Move PHPMD to Phive #852

merged 1 commit into from
Mar 28, 2020

Conversation

oliverklee
Copy link
Contributor

Also regenerate phive.xml to use the default formatting.

Part of #822

Also regenerate `phive.xml` to use the default formatting.

Part of #822
@oliverklee oliverklee added this to the 4.0.0 milestone Mar 28, 2020
@oliverklee oliverklee self-assigned this Mar 28, 2020
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering about the installed attribute in phive.xml. See comment.

I'm approving this anyway because it's not specific to this change, but something I didn't previously notice in #851.

Comment on lines +3 to +4
<phar name="php-cs-fixer" version="^2.16" installed="2.16.1" location="./tools/php-cs-fixer" copy="true"/>
<phar name="phpmd" version="^2.7" installed="2.7.0" location="./tools/phpmd" copy="true"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just noticed the installed attribute. It looks to me like something specific to a local copy and set up, and thus should be excluded from version control?

@JakeQZ JakeQZ merged commit 88bc3e0 into master Mar 28, 2020
@JakeQZ JakeQZ deleted the task/move-phpmd branch March 28, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants