Fix mapping width/height when decimal is used #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @uzegonemad, thanks for the bug fix. I appreciate that you've already provided the regression test. 👍 Could you please fix the style checker warning, add a changelog line (newest on top) and repush? Thanks! ❤️ |
|
@oliverklee Sure - CI checks are running now. |
oliverklee
approved these changes
Feb 26, 2020
oliverklee
approved these changes
Feb 26, 2020
oliverklee
requested review from
oliverklee
and removed request for
zoliszabo,
JakeQZ and
oliverklee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where if you have a width like 33.33%, the mapWidthOrHeightProperty will not correctly detect it and the style cannot be converted into an attribute.