Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Prepare the 3.0.0 release #772

Merged
merged 1 commit into from
Oct 1, 2019
Merged

[TASK] Prepare the 3.0.0 release #772

merged 1 commit into from
Oct 1, 2019

Conversation

oliverklee
Copy link
Contributor

No description provided.

@oliverklee oliverklee added this to the 3.0.0 milestone Oct 1, 2019
@oliverklee oliverklee self-assigned this Oct 1, 2019
JakeQZ
JakeQZ approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All steps up to "Have the pull request reviewed and merged" appear to be done.

@JakeQZ JakeQZ merged commit d68a8b5 into master Oct 1, 2019
@JakeQZ JakeQZ deleted the task/release branch October 1, 2019 18:21
@oliverklee
Copy link
Contributor Author

Everybody, the release is out. Thanks for all your work that helped this happen (particularly @JakeQZ - you most of the heavy lifting)! ❤️

@JakeQZ
Copy link
Contributor

JakeQZ commented Oct 19, 2019

Thanks @oliverklee. I might have put in a bit of legwork recently, but this release is the culmination of many efforts, not least your inception of the refactoring back at the start of 2018 (#479) and determination to move things forward (despite us all working here in our spare time).

During this time I’ve learnt to appreciate the beauty and power of test-driven development. Code without tests is unmaintainable. It’s also possible to develop code without testing it in a real world application – as long as the tests are well thought out 😎

I have successfully upgraded to 3.0 in a project using a ‘hacked’ version of Emogrifier – ‘hacked’ because a few additional enhancements are included, which are still in the pipeline (e.g. #512)…

@oliverklee
Copy link
Contributor Author

@JakeQZ Thank you for your kind words. ❤️ I'm happy to read that you got test-infected from working on Emogrifier. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@zoliszabo zoliszabo Awaiting requested review from zoliszabo

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @JakeQZ