Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Relax the dependency on symfony/css-selector #762

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

oliverklee
Copy link
Contributor

This reduces the probability of dependency conflicts with other packages.

symfony/css-selector 2.8 is the first version that provides the
functionality required by Emogrifier.

@oliverklee oliverklee added this to the 3.0.0 milestone Sep 30, 2019
@oliverklee oliverklee self-assigned this Sep 30, 2019
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use double-pipe for the OR operator. Otherwise I think the change is fine.

composer.json Outdated Show resolved Hide resolved
@oliverklee
Copy link
Contributor Author

Repushed.

This reduces the probability of dependency conflicts with other packages.

`symfony/css-selector` 2.8 is the first version that provides the
functionality required by Emogrifier.
@oliverklee oliverklee merged commit 9a22134 into master Sep 30, 2019
@oliverklee oliverklee deleted the task/relax-dependencies branch September 30, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants