[TASK] Test universal selector with combinators #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added “broken: …” placeholder comments for tests that would currently fail due to lack of support, and updated the README to reflect the level of support for the universal selector. Part of #723.
JakeQZ
added a commit
that referenced
this pull request
Oct 1, 2019
Looks like I was initially mistaken in believing these were not supported with Symfony CssSelector (#743). Looking again, I find that they are, so have added the missing tests and updated the README accordingly.
oliverklee
pushed a commit
that referenced
this pull request
Oct 1, 2019
Looks like I was initially mistaken in believing these were not supported with Symfony CssSelector (#743). Looking again, I find that they are, so have added the missing tests and updated the README accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added “broken: …” placeholder comments for tests that would currently fail
due to lack of support, and updated the README to reflect the level of support
for the universal selector.
Part of #723.