-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add HtmlPruner::removeRedundantClassesAfterCssInlined #724
[FEATURE] Add HtmlPruner::removeRedundantClassesAfterCssInlined #724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. Just some suggestions to help static code analysis and to help reduce the cognitive load when reading the tests.
Have made suggested changes and repushed... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Could you please rebase to resolve the conflict?
Also added section for `HtmlPruner` to the README. Closes #380.
- Return numeric array and use `list` to collate the return value, in the case of the ‘multiple return values problem’ (rather than `compact`/`extract`); - Added helper assertion methods: `assertContainsNone`, `assertContainsAll`.
d2c599c
to
4441dc0
Compare
Have done. (Now forewarned and forearmed, |
Also added section for
HtmlPruner
to the README.Closes #380.