[BUGFIX] Keep development files out of the Composer packages #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark all development-only files and directories as `export-ignore` via the `.gitattributes` file. This will keep them from being packaged in the release ZIPs provided by GitHub and in the packages downloaded by Composer with the `--prefer-dist` option (which is the default).
JakeQZ
reviewed
Aug 29, 2019
Makes sense. I'll push an update in a minute. |
|
In the article https://madewithlove.be/gitattributes/, the readme and changelog are blacklisted as well. Should we remove them as well? |
I'm not sure. They strike me as being a potentially useful in the distributed package, and they are not 'development-only'. |
|
I'm fine either way. |
JakeQZ
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark all development-only files and directories as
export-ignorevia the
.gitattributesfile. This will keep them from being packagedin the release ZIPs provided by GitHub and in the packages downloaded
by Composer with the
--prefer-distoption (which is the default).