[BUGFIX] Remove all ‘unprocessable’ tags. #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all ‘unprocessable’ tags (`<wbr>` by default) were being removed, because a ‘live’ NodeList was being iterated. This was a regression as a result of #627. Also modified related tests to include a `<body>` element in the input HTML. Prior to #627, `removeUnprocessableTags()` did not behave as documented – if elements had content it would still remove the tags (though not the content). The tests did not pick this up because `DOMDocument::loadHTML()` creates a `<body>` element if there isn’t one, and if there is text content (at the start) not inside any element, wraps it in a `<p>` element (https://secure.php.net/manual/en/domdocument.loadhtml.php#88864). (It does not create a `<p>` element if there is already a `<body>` element.)
|
An observation arises. The @oliverklee, @zoliszabo, what do you think? |
I'm for this approach. |
JakeQZ
added a commit
that referenced
this pull request
Feb 13, 2019
Added support to `AbstractHtmlProcessor` for HTML5 self-closing tags not recognized as such by PHP’s `DOMDocument` implementation. In effect this is a workaround for the issue reported in https://bugs.php.net/bug.php?id=73175. Affected tags require a self-closing slash in the HTML input to `DOMDocument` (e.g. `<wbr/>` rather than `<wbr>`), and their invalid corresponding closing tag (e.g. `</wbr>`) removing from its HTML output. Follows from discussion in #650.
JakeQZ
added a commit
that referenced
this pull request
Feb 13, 2019
Added support to `AbstractHtmlProcessor` for HTML5 self-closing tags not recognized as such by PHP’s `DOMDocument` implementation. In effect this is a workaround for the issue reported in https://bugs.php.net/bug.php?id=73175. Affected tags require a self-closing slash in the HTML input to `DOMDocument` e.g. `<wbr/>` rather than `<wbr>`, and their invalid corresponding closing tag (e.g. `</wbr>`) removing from its HTML output. Follows from discussion in #650.
JakeQZ
added a commit
that referenced
this pull request
Feb 13, 2019
Added support to `AbstractHtmlProcessor` for HTML5 self-closing tags not recognized as such by PHP’s `DOMDocument` implementation. In effect this is a workaround for the issue reported in https://bugs.php.net/bug.php?id=73175. Affected tags require a self-closing slash in the HTML input to `DOMDocument` (e.g. `<wbr/>` rather than `<wbr>`), and their invalid corresponding closing tag (e.g. `</wbr>`) removing from its HTML output. Follows from discussion in #650.
JakeQZ
added a commit
that referenced
this pull request
Feb 13, 2019
Added support to `AbstractHtmlProcessor` for HTML5 self-closing tags not recognized as such by PHP’s `DOMDocument` implementation. In effect this is a workaround for the issue reported in https://bugs.php.net/bug.php?id=73175. Affected tags require a self-closing slash in the HTML input to `DOMDocument` (e.g. `<wbr/>` rather than `<wbr>`), and their invalid corresponding closing tag (e.g. `</wbr>`) removing from its HTML output. Follows from discussion in #650.
Also required is those tags being in XML self-closing format in the input (i.e. |
oliverklee
pushed a commit
that referenced
this pull request
Mar 13, 2019
Add support to `AbstractHtmlProcessor` for HTML5 self-closing tags not recognized as such by PHP’s `DOMDocument` implementation. In effect this is a workaround for the issue reported in https://bugs.php.net/bug.php?id=73175. Affected tags require a self-closing slash in the HTML input to `DOMDocument` (e.g. `<wbr/>` rather than `<wbr>`), and their invalid corresponding closing tag (e.g. `</wbr>`) removing from its HTML output. Follows from discussion in #650.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all ‘unprocessable’ tags (
<wbr>by default) were being removed, because a‘live’ NodeList was being iterated. This was a regression as a result of #627.
Also modified related tests to include a
<body>element in the input HTML.Prior to #627,
removeUnprocessableTags()did not behave as documented – ifelements had content it would still remove the tags (though not the content).
The tests did not pick this up because
DOMDocument::loadHTML()creates a<body>element if there isn’t one, and if there is text content (at the start)not inside any element, wraps it in a
<p>element(https://secure.php.net/manual/en/domdocument.loadhtml.php#88864). (It does not
create a
<p>element if there is already a<body>element.)