Ignore invalid selectors, see #179 #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Synchro, thanks for the PR! Could you please add a regression test (i.e., a minimal unit test that fails without the fix and that passes with the fix)? Could you also please prefix the commit message subject with [BUGFIX](and, if you have more than one commit, squash those commits)? Thanks! |
| @@ -262,6 +262,10 @@ public function emogrify() | |||
| // query the body for the xpath selector | |||
| $nodesMatchingCssSelectors = $xpath->query($this->translateCssToXpath($value['selector'])); | |||
|
|
|||
| // Ignore invalid selectors | |||
| if (!$nodesMatchingCssSelectors) { | |||
There was a problem hiding this comment.
This is not always a boolean. So we should not treat it as a boolean, but do an explicit === false instead.
Synchro
added a commit
to Synchro/emogrifier
that referenced
this pull request
Jun 19, 2015
|
Done all those things, rebased, pushed. The test case was a little tricky - needed to create an error handler to trap the warnings. I've arranged it so that it eats the first error type, but lets the second go through. That can be removed when you need a test case for the other error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #179. It simply adds a check on the xpath query return value before attempting to iterate over the result set. If the xpath has failed, it just issues a continue to go to the next iteration.
This fixes the second of the two errors mentioned in the ticket, so it's effectively treating the symptom rather than the cause, but it's better than nothing! I don't know how it would be best to try to prevent the first error - somehow validate the CSS selector fragment before trying to pass it to the xpath converter?